chrome/browser/importer/external_process_importer_client.h - Issue 9235052: Fix race condition in utility process clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/external_process_importer_client.h

Issue 9235052: Fix race condition in utility process clients (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync to ToT Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/importer/external_process_importer_client.h

diff --git a/chrome/browser/importer/external_process_importer_client.h b/chrome/browser/importer/external_process_importer_client.h

index 6d31cbe8f4ff2eb00a497ea7f7049bf065cdae96..dbdf14c3feaf8216a8bbc4316d30681aeeca327c 100644

--- a/chrome/browser/importer/external_process_importer_client.h

+++ b/chrome/browser/importer/external_process_importer_client.h

@@ -109,8 +109,9 @@ class ExternalProcessImporterClient : public UtilityProcessHost::Client {

ExternalProcessImporterHost* process_importer_host_;

// Handles sending messages to the external process. Deletes itself when

- // the external process dies (see ChildProcessHost::OnChildDied).

- UtilityProcessHost* utility_process_host_;

+ // the external process dies (see

+ // BrowserChildProcessHost::OnChildDisconnected).

+ base::WeakPtr<UtilityProcessHost> utility_process_host_;

// Data to be passed from the importer host to the external importer.

const importer::SourceProfile& source_profile_;