Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: chrome/browser/importer/external_process_importer_client.h

Issue 9235052: Fix race condition in utility process clients (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync to ToT Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_IMPORTER_EXTERNAL_PROCESS_IMPORTER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_IMPORTER_EXTERNAL_PROCESS_IMPORTER_CLIENT_H_
6 #define CHROME_BROWSER_IMPORTER_EXTERNAL_PROCESS_IMPORTER_CLIENT_H_ 6 #define CHROME_BROWSER_IMPORTER_EXTERNAL_PROCESS_IMPORTER_CLIENT_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // Total number of favicons to import. 102 // Total number of favicons to import.
103 size_t total_favicons_count_; 103 size_t total_favicons_count_;
104 104
105 // Notifications received from the ProfileImportProcessHost are passed back 105 // Notifications received from the ProfileImportProcessHost are passed back
106 // to process_importer_host_, which calls the ProfileWriter to record the 106 // to process_importer_host_, which calls the ProfileWriter to record the
107 // import data. When the import process is done, process_importer_host_ 107 // import data. When the import process is done, process_importer_host_
108 // deletes itself. 108 // deletes itself.
109 ExternalProcessImporterHost* process_importer_host_; 109 ExternalProcessImporterHost* process_importer_host_;
110 110
111 // Handles sending messages to the external process. Deletes itself when 111 // Handles sending messages to the external process. Deletes itself when
112 // the external process dies (see ChildProcessHost::OnChildDied). 112 // the external process dies (see
113 UtilityProcessHost* utility_process_host_; 113 // BrowserChildProcessHost::OnChildDisconnected).
114 base::WeakPtr<UtilityProcessHost> utility_process_host_;
114 115
115 // Data to be passed from the importer host to the external importer. 116 // Data to be passed from the importer host to the external importer.
116 const importer::SourceProfile& source_profile_; 117 const importer::SourceProfile& source_profile_;
117 uint16 items_; 118 uint16 items_;
118 119
119 // Takes import data coming over IPC and delivers it to be written by the 120 // Takes import data coming over IPC and delivers it to be written by the
120 // ProfileWriter. Released by ExternalProcessImporterClient in its 121 // ProfileWriter. Released by ExternalProcessImporterClient in its
121 // destructor. 122 // destructor.
122 InProcessImporterBridge* bridge_; 123 InProcessImporterBridge* bridge_;
123 124
124 // True if import process has been cancelled. 125 // True if import process has been cancelled.
125 bool cancelled_; 126 bool cancelled_;
126 127
127 DISALLOW_COPY_AND_ASSIGN(ExternalProcessImporterClient); 128 DISALLOW_COPY_AND_ASSIGN(ExternalProcessImporterClient);
128 }; 129 };
129 130
130 #endif // CHROME_BROWSER_IMPORTER_EXTERNAL_PROCESS_IMPORTER_CLIENT_H_ 131 #endif // CHROME_BROWSER_IMPORTER_EXTERNAL_PROCESS_IMPORTER_CLIENT_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/webstore_install_helper.cc ('k') | chrome/browser/importer/external_process_importer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698