Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: chrome/browser/extensions/platform_app_browsertest.cc

Issue 9235002: Enable devtools via context menu in platform apps and popup extensions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: More feedback response Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_host.cc ('k') | chrome/browser/tab_contents/render_view_context_menu.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/platform_app_browsertest.cc
diff --git a/chrome/browser/extensions/platform_app_browsertest.cc b/chrome/browser/extensions/platform_app_browsertest.cc
index abde2eedc0e880594e1b4738ff8b590bbd7cf26c..77a6a4a27688e1bb4f9b4190de95ab2aa93886dd 100644
--- a/chrome/browser/extensions/platform_app_browsertest.cc
+++ b/chrome/browser/extensions/platform_app_browsertest.cc
@@ -141,7 +141,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_EmptyContextMenu) {
LoadAndLaunchPlatformApp("empty");
// The empty app doesn't add any context menu items, so its menu should
- // be empty.
+ // only include the developer tools.
WebContents* web_contents = GetFirstPlatformAppWebContents();
ASSERT_TRUE(web_contents);
WebKit::WebContextMenuData data;
@@ -149,7 +149,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_EmptyContextMenu) {
PlatformAppContextMenu* menu = new PlatformAppContextMenu(web_contents,
params);
menu->Init();
- ASSERT_FALSE(menu->menu_model().GetItemCount());
+ ASSERT_EQ(1, menu->menu_model().GetItemCount());
}
// Disabled until shell windows are implemented for non-GTK, non-Views toolkits.
@@ -165,8 +165,8 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_AppWithContextMenu) {
// Wait for the extension to tell us it's created an item.
ASSERT_TRUE(listener1.WaitUntilSatisfied());
- // The context_menu app has one context menu item. This is all that should
- // be in the menu, there should be no seperator.
+ // The context_menu app has one context menu item. This, along with a
+ // seperator and the developer tools, is all that should be in the menu.
Avi (use Gerrit) 2012/02/08 04:26:45 separator
WebContents* web_contents = GetFirstPlatformAppWebContents();
ASSERT_TRUE(web_contents);
WebKit::WebContextMenuData data;
@@ -174,7 +174,7 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_AppWithContextMenu) {
PlatformAppContextMenu* menu = new PlatformAppContextMenu(web_contents,
params);
menu->Init();
- ASSERT_EQ(1, menu->menu_model().GetItemCount());
+ ASSERT_EQ(3, menu->menu_model().GetItemCount());
}
// Disabled until shell windows are implemented for non-GTK, non-Views toolkits.
« no previous file with comments | « chrome/browser/extensions/extension_host.cc ('k') | chrome/browser/tab_contents/render_view_context_menu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698