chrome/browser/tab_contents/render_view_context_menu.h - Issue 9235002: Enable devtools via context menu in platform apps and popup extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.h

Issue 9235002: Enable devtools via context menu in platform apps and popup extensions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: More feedback response Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/platform_app_browsertest.cc ('K') | « chrome/browser/extensions/platform_app_browsertest.cc ('k') | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_context_menu.h

diff --git a/chrome/browser/tab_contents/render_view_context_menu.h b/chrome/browser/tab_contents/render_view_context_menu.h

index e28bb76bb50f82069f4b5a7c1a2b174ab68a3ecb..84cf9345d687f15edfc97234bc9383f71dd8b9e7 100644

--- a/chrome/browser/tab_contents/render_view_context_menu.h

+++ b/chrome/browser/tab_contents/render_view_context_menu.h

@@ -195,10 +195,10 @@ class RenderViewContextMenu : public ui::SimpleMenuModel::Delegate,

Profile* profile,

bool can_cross_incognito);

- // Gets the platform app (if any) associated with the TabContents that we're

- // in.

- const Extension* GetPlatformApp() const;

- void AppendPlatformAppItems();

+ // Gets the extension (if any) associated with the TabContents that we're in.

+ const Extension* GetExtension() const;

+ void AppendPlatformAppItems(const Extension* platform_app);

+ void AppendPopupExtensionItems();

bool AppendCustomItems();

void AppendDeveloperItems();

void AppendLinkItems();

@@ -213,6 +213,7 @@ class RenderViewContextMenu : public ui::SimpleMenuModel::Delegate,

void AppendEditableItems();

void AppendSearchProvider();

void AppendAllExtensionItems();

+ void AppendSpellingSuggestionsSubMenu();

void AppendSpellcheckOptionsSubMenu();

void AppendSpeechInputOptionsSubMenu();

// Add writing direction sub menu (only used on Mac).