Issue 9233058: Some touch-event forwarding optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9233058: Some touch-event forwarding optimization. (Closed)

Created:
8 years, 10 months ago by sadrul

Modified:
8 years, 10 months ago

Reviewers:
rjkroege, darin (slow to review)

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, klobag.chromium, Min Qin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Some touch-event forwarding optimization. If there is no touch-event handler installed for a webpage, then do not send touch-events. Corresponding webkit change: https://bugs.webkit.org/show_bug.cgi?id=77440 BUG=110237 TEST=none (suggestions?) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122163

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
M	content/browser/renderer_host/render_widget_host.h	View	1	3 chunks	+8 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host.cc	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/common/view_messages.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

Hi! Here is an attempt at http://crbug.com/110237 The webkit side of the patch is at: ...

8 years, 10 months ago (2012-01-31 16:16:09 UTC) #1

sadrul

[Note: This is for the super-simple case: if there is no touch-event handler, don't send ...

8 years, 10 months ago (2012-01-31 16:17:59 UTC) #2

sadrul

Hi! I have changed the approach slightly to make this less intrusive. The corresponding webkit ...

8 years, 10 months ago (2012-02-15 00:34:31 UTC) #4

OK, LGTM

Expand Messages | Collapse Messages