Update upload.py @ fae51921ad9d

Update upload.py @ fae51921ad9d

This version of upload.py is slightly less annoying, it won't cancel out if no
patchset title is provided and disable colors all the time.

R=cmp@chromium.org
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121826

[M-A Ruel, 2012-01-31 16:33:52]

See the diff between patchsets.

[cmp, 2012-01-31 21:48:04]

lgtm assuming no change in user experience

Let me know when you land this.

[cmp, 2012-01-31 21:48:24]

https://chromiumcodereview.appspot.com/9233057/diff/2001/tests/gcl_unittest.py
File tests/gcl_unittest.py (right):

https://chromiumcodereview.appspot.com/9233057/diff/2001/tests/gcl_unittest.p...
tests/gcl_unittest.py:316: '--issue=1',  '--title= '],
nit: remove one of the spaces after ,

[commit-bot: I haz the power, 2012-02-01 16:04:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/12001

[commit-bot: I haz the power, 2012-02-01 16:10:00]

Presubmit check for 9233057-12001 failed and returned exit status 1.

warning: code.google.com certificate with fingerprint
e9:92:78:b1:ec:f5:64:c6:fc:fb:0c:5b:ee:e0:71:18:6c:e9:42:28 not verified (check
hostfingerprints or web.cacerts config setting)
Running presubmit commit checks ...
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
push-basic.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
Branch work set up to track remote branch master from origin.
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


basic.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/basic.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


upload-stale.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/upload-stale.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


upload-local-tracking-branch.sh failed
Command
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/upload-local-tracking-branch.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
Branch work2 set up to track local branch work.
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


patch.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/patch.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


submit-from-new-dir.sh failed
Command
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/submit-from-new-dir.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds


abandon.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/abandon.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds


Presubmit checks took 343.8s to calculate.

[M-A Ruel, 2012-02-01 16:26:30]

On 2012/02/01 16:10:00, I haz the power (commit-bot) wrote:
> Presubmit check for 9233057-12001 failed and returned exit status 1.
>   File
> "/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py",
line
> 2274, in RealMain
>     form_fields.pend(("subject", title))
> AttributeError: 'list' object has no attribute 'pend'
> FAILURE: upload succeeds (needs a server running on localhost)

That's frightening. The code in the diff is correct. I have no idea why this
would be parsed incorrectly by the CQ.
I'll try a second time to see if it is deterministic.

[commit-bot: I haz the power, 2012-02-01 16:26:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/12001

[commit-bot: I haz the power, 2012-02-01 16:32:29]

Presubmit check for 9233057-12001 failed and returned exit status 1.

warning: code.google.com certificate with fingerprint
e9:92:78:b1:ec:f5:64:c6:fc:fb:0c:5b:ee:e0:71:18:6c:e9:42:28 not verified (check
hostfingerprints or web.cacerts config setting)
Running presubmit commit checks ...
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
push-basic.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
Branch work set up to track remote branch master from origin.
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


basic.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/basic.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


upload-stale.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/upload-stale.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


upload-local-tracking-branch.sh failed
Command
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/upload-local-tracking-branch.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
Branch work2 set up to track local branch work.
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


patch.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/patch.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


submit-from-new-dir.sh failed
Command
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/submit-from-new-dir.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds


abandon.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/abandon.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds


Presubmit checks took 341.7s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-02-01 18:11:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/12001

[commit-bot: I haz the power, 2012-02-01 18:17:16]

Presubmit check for 9233057-12001 failed and returned exit status 1.

warning: code.google.com certificate with fingerprint
e9:92:78:b1:ec:f5:64:c6:fc:fb:0c:5b:ee:e0:71:18:6c:e9:42:28 not verified (check
hostfingerprints or web.cacerts config setting)
Running presubmit commit checks ...
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
push-basic.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/push-basic.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
Branch work set up to track remote branch master from origin.
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


basic.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/basic.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


upload-stale.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/upload-stale.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


upload-local-tracking-branch.sh failed
Command
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/upload-local-tracking-branch.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test upstream git repo...
Setting up test git repo...
Branch work2 set up to track local branch work.
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


patch.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/patch.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds (needs a server running on localhost)
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds (needs a server running on localhost)


submit-from-new-dir.sh failed
Command
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/submit-from-new-dir.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds


abandon.sh failed
Command /mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/abandon.sh
returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1428, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 1413, in main
    return command(parser, argv[1:])
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 972, in CMDupload
    issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File
"/mnt/data/b/commit-queue/workdir/tools/depot_tools/third_party/upload.py", line
2274, in RealMain
    form_fields.pend(("subject", title))
AttributeError: 'list' object has no attribute 'pend'
FAILURE: upload succeeds


Presubmit checks took 339.4s to calculate.

[commit-bot: I haz the power, 2012-02-13 21:06:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/16001

[commit-bot: I haz the power, 2012-02-13 21:06:39]

Can't apply patch for file depot_tools/third_party/upload.py.
While running patch -p1 --forward --force;
patching file depot_tools/third_party/upload.py
Hunk #17 FAILED at 2250.
1 out of 19 hunks FAILED -- saving rejects to file
depot_tools/third_party/upload.py.rej

[commit-bot: I haz the power, 2012-02-13 23:36:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/21001

[commit-bot: I haz the power, 2012-02-13 23:36:39]

Can't apply patch for file depot_tools/third_party/upload.py.
While running patch -p1 --forward --force;
patching file depot_tools/third_party/upload.py
Hunk #17 FAILED at 2250.
1 out of 19 hunks FAILED -- saving rejects to file
depot_tools/third_party/upload.py.rej

[commit-bot: I haz the power, 2012-02-14 00:35:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/21001

[commit-bot: I haz the power, 2012-02-14 00:35:30]

Can't apply patch for file depot_tools/third_party/upload.py.
While running patch -p1 --forward --force;
patching file depot_tools/third_party/upload.py
Hunk #17 FAILED at 2250.
1 out of 19 hunks FAILED -- saving rejects to file
depot_tools/third_party/upload.py.rej

[commit-bot: I haz the power, 2012-02-14 00:36:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/21001

[commit-bot: I haz the power, 2012-02-14 00:36:33]

Commit queue had an internal error.
Something went really wrong, probably a crash, a hickup or
simply the monkeys went out for diner.
The relevant dude was pinged already.

[M-A Ruel, 2012-02-14 00:38:30]

On 2012/02/14 00:36:33, I haz the power (commit-bot) wrote:
> Commit queue had an internal error.
> Something went really wrong, probably a crash, a hickup or
> simply the monkeys went out for diner.
> The relevant dude was pinged already.

Sorry for the noise, I'm unable to test outside of the CQ and it is a unicode
encoding bug.

[commit-bot: I haz the power, 2012-02-14 00:38:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/21001

[commit-bot: I haz the power, 2012-02-14 00:41:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/21001

[commit-bot: I haz the power, 2012-02-14 00:41:49]

Can't apply patch for file depot_tools/third_party/upload.py.
While running patch -p1 --forward --force;
patching file depot_tools/third_party/upload.py
Hunk #17 FAILED at 2250.
1 out of 19 hunks FAILED -- saving rejects to file
depot_tools/third_party/upload.py.rej

[commit-bot: I haz the power, 2012-02-14 02:27:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9233057/21001

[commit-bot: I haz the power, 2012-02-14 02:34:17]

Change committed as 121826

[M-A Ruel, 2012-02-14 02:35:41]

FTR, it needed https://chromiumcodereview.appspot.com/9387024/ to fix the
unicode upgrade issue.