Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tests/gcl_unittest.py

Issue 9233057: Update upload.py @ fae51921ad9d (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Rebase against HEAD Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gcl_unittest.py
diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py
index 4ea69b446382d8afc5eb7ddf421e54d80f7f77b7..bd6e5b984176413ddbbf42f5ecd9633c985086f0 100755
--- a/tests/gcl_unittest.py
+++ b/tests/gcl_unittest.py
@@ -187,7 +187,6 @@ class ChangeInfoUnittest(GclTestsBase):
'UpdateRietveldDescription',
'description', 'issue', 'name',
'needs_upload', 'patch', 'patchset', 'reviewers', 'rietveld',
- 'subject',
]
# If this test fails, you should add the relevant test.
self.compareMembers(
@@ -314,7 +313,7 @@ class CMDuploadUnittest(GclTestsBase):
gcl.GenerateDiff(files)
gcl.upload.RealMain(['upload.py', '-y', '--server=https://my_server',
'-r', 'georges@example.com',
- '--message=\'\'', '--issue=1'],
+ '--issue=1', '--title= '],
change_info.patch).AndReturn(("1",
"2"))
change_info.GetLocalRoot().AndReturn('proout')
@@ -358,7 +357,7 @@ class CMDuploadUnittest(GclTestsBase):
gcl.GenerateDiff(change_info.GetFileNames())
gcl.upload.RealMain(
[ 'upload.py', '-y', '--server=https://my_server', '--server=a',
- '--description_file=descfile', '--message=deescription'],
+ '--file=descfile'],
change_info.patch).AndReturn(("1", "2"))
gcl.os.remove('descfile')
change_info.SendToRietveld("/lint/issue%s_%s" % ('1', '2'), timeout=1)
@@ -398,9 +397,9 @@ class CMDuploadUnittest(GclTestsBase):
gcl.os.getcwd().AndReturn('somewhere')
gcl.os.chdir(change_info.GetLocalRoot())
gcl.GenerateDiff(change_info.GetFileNames())
- gcl.upload.RealMain(['upload.py', '-y', '--server=https://my_server',
- "--description_file=descfile",
- "--message=deescription"], change_info.patch).AndReturn(("1", "2"))
+ gcl.upload.RealMain(
+ ['upload.py', '-y', '--server=https://my_server', "--file=descfile" ],
+ change_info.patch).AndReturn(("1", "2"))
gcl.os.remove('descfile')
change_info.SendToRietveld("/lint/issue%s_%s" % ('1', '2'), timeout=1)
gcl.os.chdir('somewhere')
@@ -457,7 +456,7 @@ class CMDuploadUnittest(GclTestsBase):
gcl.GenerateDiff(files)
gcl.upload.RealMain(['upload.py', '-y', '--server=https://my_server',
'--reviewers=georges@example.com',
- '--message=\'\'', '--issue=1'],
+ '--issue=1', '--title= '],
change_info.patch).AndReturn(("1", "2"))
change_info.Save()
change_info.PrimeLint()
@@ -486,7 +485,7 @@ class CMDuploadUnittest(GclTestsBase):
gcl.GenerateDiff(change_info.GetFileNames())
gcl.upload.RealMain(['upload.py', '-y', '--server=https://my_server',
'--reviewers=foo@example.com,bar@example.com',
- '--message=\'\'', '--issue=1'],
+ '--issue=1', '--title= '],
change_info.patch).AndReturn(("1", "2"))
change_info.Save()
change_info.PrimeLint()
« no previous file with comments | « git_cl.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698