Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 9225001: Remove two static initializers (media/base/{buffers,media_log}.cc) (Closed)

Created:
8 years, 11 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 11 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

buffers.cc: replaced global TimeDelta constants with fully-inlined functions. media_log.cc: replaced global AtomicSequenceNumber with LazyInstance. BUG=94925 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118026

Patch Set 1 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -60 lines) Patch
M media/base/buffers.h View 1 chunk +6 lines, -2 lines 0 comments Download
M media/base/buffers.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/base/clock.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_log.cc View 3 chunks +4 lines, -2 lines 2 comments Download
M media/base/pts_stream.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/base/pts_stream_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/seekable_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/seekable_buffer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/seekable_buffer_unittest.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M media/filters/audio_renderer_algorithm_base.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/media/video_renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/video_renderer_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Ami GONE FROM CHROMIUM
FYI "extern inline", at least in gcc, means never emit assembly for the function; it'll ...
8 years, 11 months ago (2012-01-14 22:49:53 UTC) #1
Ami GONE FROM CHROMIUM
Added media_log.cc to this patch since it was easy and the last static initializer under ...
8 years, 11 months ago (2012-01-14 23:13:21 UTC) #2
scherkus (not reviewing)
LGTM
8 years, 11 months ago (2012-01-17 16:42:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/9225001/19
8 years, 11 months ago (2012-01-17 16:47:43 UTC) #4
commit-bot: I haz the power
Try job failure for 9225001-19 (retry) on mac_rel for step "ui_tests". It's a second try, ...
8 years, 11 months ago (2012-01-17 19:50:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/9225001/19
8 years, 11 months ago (2012-01-17 22:13:30 UTC) #6
commit-bot: I haz the power
Change committed as 118026
8 years, 11 months ago (2012-01-18 03:29:40 UTC) #7
Nico
Thanks! http://codereview.chromium.org/9225001/diff/19/media/base/media_log.cc File media/base/media_log.cc (right): http://codereview.chromium.org/9225001/diff/19/media/base/media_log.cc#newcode20 media/base/media_log.cc:20: static base::LazyInstance<base::AtomicSequenceNumber> media_log_count = This needs LeakyLakyInstanceTraits as ...
8 years, 11 months ago (2012-01-18 03:48:31 UTC) #8
Ami GONE FROM CHROMIUM
8 years, 11 months ago (2012-01-18 04:52:31 UTC) #9
http://codereview.chromium.org/9225001/diff/19/media/base/media_log.cc
File media/base/media_log.cc (right):

http://codereview.chromium.org/9225001/diff/19/media/base/media_log.cc#newcode20
media/base/media_log.cc:20: static
base::LazyInstance<base::AtomicSequenceNumber> media_log_count =
On 2012/01/18 03:48:31, Nico wrote:
> This needs LeakyLakyInstanceTraits as 2nd template parameter, else it
registers
> something to run atexit()

As you wish: https://chromiumcodereview.appspot.com/9253006

Powered by Google App Engine
This is Rietveld 408576698