Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: tools/testing/perf_testing/create_graph.py

Issue 9214005: Get Firefox and IE working again with Object.defineProperty! (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/perf_testing/create_graph.py
===================================================================
--- tools/testing/perf_testing/create_graph.py (revision 3300)
+++ tools/testing/perf_testing/create_graph.py (working copy)
@@ -511,11 +511,14 @@
self.add_svn_revision_to_trace(self.trace_file)
dart_sdk = os.path.join(os.getcwd(), utils.GetBuildRoot(utils.GuessOS(),
'release', 'ia32'), 'dart-sdk')
+ #TODO(efortuna): Complain to whesse to get frog and froglib flags
Siggi Cherem (dart-lang) 2012/01/13 18:43:34 Rephrase :), maybe simply say: TODO(efortuna): en
+ #implemented in test.dart. Until then we'll be testing frogsh instead
+ #of minfrog!
run_cmd([os.path.join('.', 'tools', 'testing', 'bin', system,
'dart' + suffix), os.path.join('tools', 'test.dart'),
- '--component=webdriver', '--flag=%s,--frog=%s,--froglib=%s' % \
- (browser, os.path.join(dart_sdk, 'bin', 'frogc'),
- os.path.join(dart_sdk, 'lib')), '--report',
+ '--component=webdriver',
+ '--browser=%s' % browser, '--frog=%s' % os.path.join(dart_sdk, 'bin',
+ 'frogc'),'--froglib=%s' % os.path.join(dart_sdk, 'lib')), '--report',
Siggi Cherem (dart-lang) 2012/01/13 18:43:34 space after ,
'--timeout=20', '--progress=color', '--mode=release', '-j1',
self.test_type], self.trace_file, append=True)
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698