Get Firefox and IE working again with Object.defineProperty!

tools/testing/perf_testing/create_graph.py

 #!/usr/bin/python
 
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import datetime
 import math
 from matplotlib.font_manager import FontProperties
 import matplotlib.pyplot as plt
@@ skipping 493 matching lines @@
     suffix = ''
     if platform.system() == 'Windows':
       suffix = '.exe'
     for browser in get_browsers():
       current_file = 'correctness%s-%s' % (self.cur_time, browser)
       self.trace_file = os.path.join('tools', 'testing',
           'perf_testing', self.result_folder_name, current_file)
       self.add_svn_revision_to_trace(self.trace_file)
       dart_sdk = os.path.join(os.getcwd(), utils.GetBuildRoot(utils.GuessOS(),
           'release', 'ia32'), 'dart-sdk')
+      #TODO(efortuna): Complain to whesse to get frog and froglib flags

[Siggi Cherem (dart-lang), 2012/01/13 18:43:34]

Rephrase :), maybe simply say:

TODO(efortuna): ensure that the frog and froglib flags work when they get
implemented in test.dart (Bug #1046)

+      #implemented in test.dart. Until then we'll be testing frogsh instead
+      #of minfrog!
       run_cmd([os.path.join('.', 'tools', 'testing', 'bin', system, 
           'dart' + suffix), os.path.join('tools', 'test.dart'), 
-          '--component=webdriver', '--flag=%s,--frog=%s,--froglib=%s' % \
-          (browser, os.path.join(dart_sdk, 'bin', 'frogc'), 
-          os.path.join(dart_sdk, 'lib')), '--report',
+          '--component=webdriver', 
+          '--browser=%s' % browser, '--frog=%s' % os.path.join(dart_sdk, 'bin',
+          'frogc'),'--froglib=%s' % os.path.join(dart_sdk, 'lib')), '--report',

[Siggi Cherem (dart-lang), 2012/01/13 18:43:34]

space after ,

           '--timeout=20', '--progress=color', '--mode=release', '-j1',
           self.test_type], self.trace_file, append=True)
 
   def process_file(self, afile):
     """Given a trace file, extract all the relevant information out of it to
     determine the number of correctly passing tests.
     
     Arguments:
       afile the filename string"""
     browser = afile.rpartition('-')[2]
@@ skipping 193 matching lines @@
       if has_new_code():
         run_test_sequence(cl, size, language, perf)
       else:
         time.sleep(SLEEP_TIME)
   else:
     run_test_sequence(cl, size, language, perf)
 
 if __name__ == '__main__':
   main()