Issue 9214004: Add UpgradeToHttps() to reliably and forcibly upgrade all urls to https

Issue 9214004: Add UpgradeToHttps() to reliably and forcibly upgrade all urls to https (Closed)

Created:
8 years, 11 months ago by M-A Ruel

Modified:
8 years, 11 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, Dirk Pranke, M-A Ruel, Evan Martin

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Add UpgradeToHttps() to reliably and forcibly upgrade all urls to https. Enable it for git-cl and gcl. R=nsylvain@chromium.org BUG=107838 TEST=New connections go through https:// Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117857

Patch Set 2 : Fix for nul url #

Total comments: 2

Patch Set 4 : Fix git-cl tests, do not override url with port number #

Patch Set 5 : Add processing of VIEW_VC for gcl #

Patch Set 6 : Saner processing. Had to workaround urlparse default behavior #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -66 lines)			Patch
M	gcl.py	View	1 2 3 4	2 chunks	+3 lines, -5 lines	0 comments	Download
M	gclient_utils.py	View	1 2 3 4 5	3 chunks	+30 lines, -1 line	0 comments	Download
M	git_cl.py	View	1 2	7 chunks	+23 lines, -26 lines	0 comments	Download
M	tests/gcl_unittest.py	View	1 2 3 4	12 chunks	+19 lines, -17 lines	0 comments	Download
M	tests/gclient_utils_test.py	View	1 2 3 4 5	2 chunks	+41 lines, -15 lines	0 comments	Download
M	tests/git_cl_test.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nsylvain

lgtm https://chromiumcodereview.appspot.com/9214004/diff/3001/git_cl.py File git_cl.py (right): https://chromiumcodereview.appspot.com/9214004/diff/3001/git_cl.py#newcode1233 git_cl.py:1233: # Assume it's a URL to the patch. ...

8 years, 11 months ago (2012-01-13 21:34:48 UTC) #2

M-A Ruel

https://chromiumcodereview.appspot.com/9214004/diff/3001/git_cl.py File git_cl.py (right): https://chromiumcodereview.appspot.com/9214004/diff/3001/git_cl.py#newcode1233 git_cl.py:1233: # Assume it's a URL to the patch. Default ...

8 years, 11 months ago (2012-01-16 14:45:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9214004/6001

8 years, 11 months ago (2012-01-16 14:53:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9214004/15001

8 years, 11 months ago (2012-01-16 16:57:09 UTC) #5

Change committed as 117857

Expand Messages | Collapse Messages