Add UpgradeToHttps() to reliably and forcibly upgrade all urls to https

gcl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 276 matching lines @@
     self._description = None
     self._subject = None
     self._reviewers = None
     self._set_description(description)
     if files is None:
       files = []
     self._files = files
     self.patch = None
     self._local_root = local_root
     self.needs_upload = needs_upload
-    self.rietveld = rietveld_url
-    if not self.rietveld:
-      # Set the default value.
-      self.rietveld = GetCodeReviewSetting('CODE_REVIEW_SERVER')
+    self.rietveld = gclient_utils.UpgradeToHttps(
+        rietveld_url or GetCodeReviewSetting('CODE_REVIEW_SERVER'))
     self._rpc_server = None
 
   def _get_description(self):
     return self._description
 
   def _set_description(self, description):
     # TODO(dpranke): Cloned from git_cl.py. These should be shared.
     if not description:
       self._description = description
       return
@@ skipping 721 matching lines @@
     finally:
       os.remove(commit_filename)
   finally:
     os.remove(targets_filename)
   if output.find("Committed revision") != -1:
     change_info.Delete()
 
     if change_info.issue:
       revision = re.compile(".*?\nCommitted revision (\d+)",
                             re.DOTALL).match(output).group(1)
-      viewvc_url = GetCodeReviewSetting("VIEW_VC")
+      viewvc_url = gclient_utils.UpgradeToHttps(GetCodeReviewSetting('VIEW_VC'))
       change_info.description += '\n'
       if viewvc_url:
         change_info.description += "\nCommitted: " + viewvc_url + revision
       change_info.CloseIssue()
   return 0
 
 
 def CMDchange(args):
   """Creates or edits a changelist.
 
@@ skipping 408 matching lines @@
       raise
     print >> sys.stderr, (
         'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
         'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
     return 1
 
 
 if __name__ == "__main__":
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))