git_cl.py - Issue 9214002: Dedupe codereview.settings parsing code. Add more testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 9214002: Dedupe codereview.settings parsing code. Add more testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 759caf6a87c7e48c380d954d4d39c1ff52c9a758..f68e4930eb38d5b4145dd0dbc0f6de732ca13ac0 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -717,12 +717,7 @@ def FindCodereviewSettingsFile(filename='codereview.settings'):

def LoadCodereviewSettingsFromFile(fileobj):

"""Parse a codereview.settings file and updates hooks."""

- keyvals = {}

- for line in fileobj.read().splitlines():

- if not line or line.startswith("#"):

- continue

- k, v = line.split(": ", 1)

- keyvals[k] = v

+ keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())

def SetProperty(name, setting, unset_error_ok=False):

fullname = 'rietveld.' + name

« no previous file with comments | « gclient_utils.py ('k') | tests/gclient_utils_test.py » ('j') | no next file with comments »