Implements keyboard events for RenderViewTest....

Implements keyboard events for RenderViewTest.This change implements a function RenderViewTest::SendKeyEvent() that sends a keyboard event to a RenderView object.To emulate not only US keyboards but also non-US keyboards, this change adds a new class "MockKeyboard", which implements a mapping function from a triple <keyboard type, key code, modifiers> to a Unicode character so that engineers can write RenderViewTest cases without taking care of keyboard types.As samples for this new function, I updated my test RenderViewTest.OnHandleKeyboardEvent and added another test RenderViewTest.InsertCharacters.I wish this class help engineers write more RenderViewTest cases.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15748

[brettw, 2009-04-28 06:46:13]

LGTM, just have a few minor suggestions. It looks much nicer!

http://codereview.chromium.org/92122/diff/3041/2055
File chrome/renderer/mock_keyboard.h (right):

http://codereview.chromium.org/92122/diff/3041/2055#newcode15
Line 15: enum MockKeyboardLayout {
What do you think about putting these two enums inside the class? I try to avoid
things being in the global scope, since this makes it more clear which class
they are associated with.  If we do this, we don't need the MOCK_ prefix, so it
can just be MockKeyboard::LAYOUT_*

http://codereview.chromium.org/92122/diff/3041/2055#newcode85
Line 85: wchar_t GetCharacterCode(MockKeyboardLayout layout,
Is wchar_t enough here? What if it is a non-BMP character, or can Windows not do
that? If non-BMP characters aren't possible on Windows, I agree that wchar_t is
good here.

http://codereview.chromium.org/92122/diff/3041/2055#newcode96
Line 96: };
Is DISALLOW_COPY_AND_ASSIGN appropriate here and in the *Win class?

[jungshik at Google, 2009-05-07 00:11:32]

LGTM. Sorry for the delay.

http://codereview.chromium.org/92122/diff/2103/3060
File chrome/renderer/mock_keyboard.h (right):

http://codereview.chromium.org/92122/diff/2103/3060#newcode86
Line 86: // layout, key code, and modifiers.
I'm aware that you changed the out param to a string to support a non-BMP
character on Windows. I wonder if it's always a single Unicode character. I
guess not.  

Aha. I saw your comment in other files. Perhaps, it's better to move that here
and explain about |output| and |length| here.

http://codereview.chromium.org/92122/diff/2103/3060#newcode95
Line 95: MockKeyboardWin driver_;
nit: I was a little confused with the relationship between MockKeyboard and
MockKeyboardWin class. Wouldn't it be better to use a name that won't be
mistaken for a class inheritance relation. I don't have a good name, but how
about MockKeyboardDriverFoo (Win, Mac and Linux)?