Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2798)

Unified Diff: base/debug_util_unittest.cc

Issue 92112: Disable symbol resolution checks in debug_util_unitest.cc unittest. (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug_util_unittest.cc
diff --git a/base/debug_util_unittest.cc b/base/debug_util_unittest.cc
index 2636e45f04cc4f2ecc88ca803cbf0ef438992253..418dc0afc33f951cd4129def139ba37e3c766fce 100644
--- a/base/debug_util_unittest.cc
+++ b/base/debug_util_unittest.cc
@@ -31,6 +31,10 @@ TEST(StackTrace, OutputToStream) {
return;
}
+#if 0
+//TODO(ajwong): Disabling checking of symbol resolution since it depends
+// on whether or not symbols are present, and there are too many
+// configurations to reliably ensure that symbols are findable.
#if defined(OS_MACOSX)
// Symbol resolution via the backtrace_symbol funciton does not work well
@@ -69,4 +73,5 @@ TEST(StackTrace, OutputToStream) {
<< backtrace_message;
#endif // define(OS_MACOSX)
+#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698