Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: base/debug_util_unittest.cc

Issue 92112: Disable symbol resolution checks in debug_util_unitest.cc unittest. (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 #include <string> 6 #include <string>
7 7
8 #include "base/debug_util.h" 8 #include "base/debug_util.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 13 matching lines...) Expand all
24 return; 24 return;
25 } 25 }
26 26
27 // Check if the output has symbol initialization warning. If it does, fail. 27 // Check if the output has symbol initialization warning. If it does, fail.
28 if (backtrace_message.find("Dumping unresolved backtrace") != 28 if (backtrace_message.find("Dumping unresolved backtrace") !=
29 std::string::npos) { 29 std::string::npos) {
30 LOG(ERROR) << "Unable to resolve symbols. Skipping rest of test."; 30 LOG(ERROR) << "Unable to resolve symbols. Skipping rest of test.";
31 return; 31 return;
32 } 32 }
33 33
34 #if 0
35 //TODO(ajwong): Disabling checking of symbol resolution since it depends
36 // on whether or not symbols are present, and there are too many
37 // configurations to reliably ensure that symbols are findable.
34 #if defined(OS_MACOSX) 38 #if defined(OS_MACOSX)
35 39
36 // Symbol resolution via the backtrace_symbol funciton does not work well 40 // Symbol resolution via the backtrace_symbol funciton does not work well
37 // in OsX. 41 // in OsX.
38 // See this thread: 42 // See this thread:
39 // 43 //
40 // http://lists.apple.com/archives/darwin-dev/2009/Mar/msg00111.html 44 // http://lists.apple.com/archives/darwin-dev/2009/Mar/msg00111.html
41 // 45 //
42 // Just check instead that we find our way back to the "start" symbol 46 // Just check instead that we find our way back to the "start" symbol
43 // which should be the first symbol in the trace. 47 // which should be the first symbol in the trace.
(...skipping 18 matching lines...) Expand all
62 #define __func__ __FUNCTION__ 66 #define __func__ __FUNCTION__
63 #endif 67 #endif
64 68
65 // Expect to find this function as well. 69 // Expect to find this function as well.
66 // Note: This will fail if not linked with -rdynamic (aka -export_dynamic) 70 // Note: This will fail if not linked with -rdynamic (aka -export_dynamic)
67 EXPECT_TRUE(backtrace_message.find(__func__) != std::string::npos) 71 EXPECT_TRUE(backtrace_message.find(__func__) != std::string::npos)
68 << "Expected to find " << __func__ << " in backtrace:\n" 72 << "Expected to find " << __func__ << " in backtrace:\n"
69 << backtrace_message; 73 << backtrace_message;
70 74
71 #endif // define(OS_MACOSX) 75 #endif // define(OS_MACOSX)
76 #endif
72 } 77 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698