Send an IM when gcl commit <change> --no_presubmit is used

Send an IM when gcl commit <change> --no_presubmit is used

R=cmp@chromium.org
BUG=25940
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117851

[cmp, 2012-01-13 21:18:29]

lgtm

This looks a lot like the last CL's stack would, unless line numbers are sent. 
Are they?

[M-A Ruel, 2012-01-13 21:25:56]

On 2012/01/13 21:18:29, cmp wrote:
> lgtm
> 
> This looks a lot like the last CL's stack would, unless line numbers are sent.

> Are they?

No the other one is for gcl.py. I sent them independently so I can revert only
one of the CL if I broke one of the tool.

[cmp, 2012-01-13 21:30:03]

On 2012/01/13 21:25:56, Marc-Antoine Ruel wrote:
> No the other one is for gcl.py. I sent them independently so I can revert only
> one of the CL if I broke one of the tool.

Sending them separately makes sense.

I was just pointing out that the exact strings were very similar:

From http://codereview.chromium.org/9211013/:
+        'GclHooksBypassedCommit',
+        'Issue %s/%s bypassed hook when committing' %
+        (change_info.rietveld, change_info.issue))
From http://codereview.chromium.org/9112039/:
+        'GitClHooksBypassedCommit',
+        'Issue %s/%s bypassed hook when committing' %
+        (cl.GetRietveldServer(), cl.GetIssue()))

I didn't think it bother to read the messages clearly enough, though, and it's
obvious that the message "Gcl..." or "GitCl..." is exactly what's needed to know
where the message is coming from.  I was also generally curious if we get stack
traces that include line number information, but I don't believe that's the
case.

Feel free to disregard.

[commit-bot: I haz the power, 2012-01-16 14:01:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9211013/1

[commit-bot: I haz the power, 2012-01-16 14:20:02]

Change committed as 117851

[jam, 2012-01-17 04:31:39]

this is being hit for drover and also uploading. when uploading refactoring
changes which touch XX or XXX files, presubmit checks sometimes take a few
minutes to run. i only run them once, and then when uploading small changes
i skip them.. all these sending callstacks is confusing. can you just ping
a url silently instead of doing this?

On Mon, Jan 16, 2012 at 6:20 AM, <commit-bot@chromium.org> wrote:

> Change committed as 117851
>
>
http://codereview.chromium.**org/9211013/<http://codereview.chromium.org/9211...
>

[M-A Ruel, 2012-01-17 15:10:58]

It's an oversight of my part, fixing.

Le 16 janvier 2012 23:31, John Abd-El-Malek <jam@chromium.org> a écrit :

> this is being hit for drover and also uploading. when uploading
> refactoring changes which touch XX or XXX files, presubmit checks sometimes
> take a few minutes to run. i only run them once, and then when uploading
> small changes i skip them.. all these sending callstacks is confusing. can
> you just ping a url silently instead of doing this?
>
>
> On Mon, Jan 16, 2012 at 6:20 AM, <commit-bot@chromium.org> wrote:
>
>> Change committed as 117851
>>
>>
http://codereview.chromium.**org/9211013/<http://codereview.chromium.org/9211...
>>
>
>