gcl.py - Issue 9211013: Send an IM when gcl commit <change> --no_presubmit is used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 9211013: Send an IM when gcl commit <change> --no_presubmit is used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gcl.py

diff --git a/gcl.py b/gcl.py

index 77b3ae9725b52fdc070469b025715788e9e4cee0..e5a2a85a96d9784a410c8cf8c5a591f9439861d8 100755

--- a/gcl.py

+++ b/gcl.py

@@ -755,6 +755,10 @@ def GenerateDiff(files):

def OptionallyDoPresubmitChecks(change_info, committing, args):

if FilterFlag(args, "--no_presubmit") or FilterFlag(args, "--force"):

+ breakpad.SendStack(

+ 'GclHooksBypassedCommit',

+ 'Issue %s/%s bypassed hook when committing' %

+ (change_info.rietveld, change_info.issue))

return presubmit_support.PresubmitOutput()

return DoPresubmitChecks(change_info, committing, True)

« no previous file with comments | « no previous file | no next file » | no next file with comments »