Issue 921001: Replace symlink to separate repository with real file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 921001: Replace symlink to separate repository with real file (Closed)

Created:
10 years, 9 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
Sam Leffler, tedbo

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Replace symlink to build_image with real file.

Patch Set 1 #

Patch Set 2 : Only move build_image #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+382 lines, -1 line)			Patch
	A	src/scripts/build_image	View		1 chunk	+0 lines, -1 line	0 comments	Download
		src/scripts/build_image	View	1	1 chunk	+382 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tedbo

10 years, 9 months ago (2010-03-15 20:11:51 UTC) #3

LGTM

We had a few rounds of discussions and decided (for now) to only move
build_image to the main tree.

ted

On Mon, Mar 15, 2010 at 10:15 AM,  <sleffler@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/921001
>

Expand Messages | Collapse Messages