Fix focus rects for checkboxes and radio buttons:...

Fix focus rects for checkboxes and radio buttons:

- add concept of default insets to view which get added to any other insets provided by the user. used by label to provide room for a focus border.
- provide the ability for the label to paint its focus border even if it isn't focused. needed because the outer container (the checkbox) gets focus but the inner label does not, however the label knows best the location of its text around which the focus border must be drawn.

please note:
- also make it easier to click checkboxes by not resetting mouse_pressed_handler_ in RootView when a view decides it doesn't want to handle a drag. this is so we can still receive mousereleased notifications when the mouse is released... it's "difficult" to click checkboxes and radio buttons when you accidentally drag a little on their label. (this is the root view change).

- fix slight alignment issue on the general page of options.


Also fix a slight error in my last radio checkbox - clicking on a checked radio button should still focus it.

http://crbug.com/10834

TEST=visit options, Minor Tweaks. click the "always ask before downloading" checkbox and observe that the focus rect tightly surrounds the text label instead of stretching to the right side of the dialog.
Visit options, click an already-checked radio button. observe that it takes focus.
Visit options, click on any checkbox or radio button, drag slightly then release (still within the bounds of the item). note the item is now toggled or selected. click down then drag out and release, note that it is not toggled or selected.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14265

[Ben Goodger (Google), 2009-04-22 04:19:52]

this one is rich in nuance.

[sky, 2009-04-22 15:08:16]

http://codereview.chromium.org/92004/diff/1/10
File chrome/views/controls/button/radio_button.cc (right):

http://codereview.chromium.org/92004/diff/1/10#newcode90
Line 90: SetChecked(!checked());
!checked() has to be true to get here, so I think SetChecked(true) is a bit
clearer.

http://codereview.chromium.org/92004/diff/1/6
File chrome/views/controls/label.cc (right):

http://codereview.chromium.org/92004/diff/1/6#newcode155
Line 155: flags | ChromeCanvas::MULTI_LINE);
Should that be ComputeMultiLineFlags()?

http://codereview.chromium.org/92004/diff/1/11
File chrome/views/view.h (right):

http://codereview.chromium.org/92004/diff/1/11#newcode903
Line 903: void set_default_insets(const gfx::Insets& default_insets) {
I'm not sure how useful this is outside of label. Should we just keep it in
label for now?

[Ben Goodger (Google), 2009-04-22 19:50:02]

Updated.

On 2009/04/22 15:08:16, sky wrote:
> http://codereview.chromium.org/92004/diff/1/10
> File chrome/views/controls/button/radio_button.cc (right):
> 
> http://codereview.chromium.org/92004/diff/1/10#newcode90
> Line 90: SetChecked(!checked());
> !checked() has to be true to get here, so I think SetChecked(true) is a bit
> clearer.
> 
> http://codereview.chromium.org/92004/diff/1/6
> File chrome/views/controls/label.cc (right):
> 
> http://codereview.chromium.org/92004/diff/1/6#newcode155
> Line 155: flags | ChromeCanvas::MULTI_LINE);
> Should that be ComputeMultiLineFlags()?
> 
> http://codereview.chromium.org/92004/diff/1/11
> File chrome/views/view.h (right):
> 
> http://codereview.chromium.org/92004/diff/1/11#newcode903
> Line 903: void set_default_insets(const gfx::Insets& default_insets) {
> I'm not sure how useful this is outside of label. Should we just keep it in
> label for now?

[sky, 2009-04-22 19:59:12]

LGTM