Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6337)

Unified Diff: chrome/views/controls/button/checkbox.h

Issue 92004: Fix focus rects for checkboxes and radio buttons:... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/gfx/insets.h ('k') | chrome/views/controls/button/checkbox.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/views/controls/button/checkbox.h
===================================================================
--- chrome/views/controls/button/checkbox.h (revision 14145)
+++ chrome/views/controls/button/checkbox.h (working copy)
@@ -41,7 +41,7 @@
// Overridden from View:
virtual gfx::Size GetPreferredSize();
virtual void Layout();
- virtual void Paint(ChromeCanvas* canvas);
+ virtual void PaintFocusBorder(ChromeCanvas* canvas);
virtual View* GetViewForPoint(const gfx::Point& point);
virtual View* GetViewForPoint(const gfx::Point& point,
bool can_create_floating);
@@ -50,6 +50,9 @@
virtual void OnMouseExited(const MouseEvent& e);
virtual bool OnMousePressed(const MouseEvent& e);
virtual void OnMouseReleased(const MouseEvent& e, bool canceled);
+ virtual bool OnMouseDragged(const MouseEvent& e);
+ virtual void WillGainFocus();
+ virtual void WillLoseFocus();
protected:
virtual std::string GetClassName() const;
@@ -58,14 +61,14 @@
virtual void CreateWrapper();
virtual void InitBorder();
+ // Returns true if the event (in Checkbox coordinates) is within the bounds of
+ // the label.
+ bool HitTestLabel(const MouseEvent& e);
+
private:
// Called from the constructor to create and configure the checkbox label.
void Init(const std::wstring& label_text);
- // Returns true if the event (in Checkbox coordinates) is within the bounds of
- // the label.
- bool HitTestLabel(const MouseEvent& e);
-
// The checkbox's label. We don't use the OS version because of transparency
// and sizing issues.
Label* label_;
« no previous file with comments | « chrome/common/gfx/insets.h ('k') | chrome/views/controls/button/checkbox.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698