Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 9196001: Set -Wno-unused-result for Chrome OS build (Closed)

Created:
8 years, 11 months ago by mazda
Modified:
8 years, 11 months ago
Reviewers:
Yusuke Sato
CC:
chromium-reviews
Visibility:
Public.

Description

Set -Wno-unused-result for Chrome OS build Now gcc in chroot is updated to 4.6 and this option is available. BUG=chromium-os:18541 TEST='emerge-stumpy chromeos-chrome' succeeds in chroot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mazda
Can I ask you to review this change?
8 years, 11 months ago (2012-01-12 12:45:38 UTC) #1
Yusuke Sato
On 2012/01/12 12:45:38, mazda wrote: > Can I ask you to review this change? lgtm
8 years, 11 months ago (2012-01-13 05:00:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/9196001/1
8 years, 11 months ago (2012-01-13 05:11:52 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-13 06:28:04 UTC) #4
Change committed as 117615

Powered by Google App Engine
This is Rietveld 408576698