Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3312)

Unified Diff: build/common.gypi

Issue 9196001: Set -Wno-unused-result for Chrome OS build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 9c1d9dbdd965d46f33e2e23d43d382ac138320c9..2551d3c471669229d1be2ceae3fe2254852ef552 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1280,17 +1280,12 @@
'-Wsign-compare',
]
}],
- [ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android" and chromeos==0', {
+ [ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android"', {
'cflags': [
# Don't warn about ignoring the return value from e.g. close().
# This is off by default in some gccs but on by default in others.
- # Currently this option is not set for Chrome OS build because
- # the current version of gcc (4.3.4) used for building Chrome in
- # Chrome OS chroot doesn't support this option.
- # BSD systems do not support this option either, since they are
- # usually using gcc 4.2.1, which does not have this flag yet.
- # TODO(mazda): remove the conditional for Chrome OS when gcc
- # version is upgraded.
+ # BSD systems do not support this option, since they are usually
+ # using gcc 4.2.1, which does not have this flag yet.
'-Wno-unused-result',
],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698