Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 9192014: Replace WGC3D visibility extension with resource_usage extension. [Part 2 of 3] (Closed)

Created:
8 years, 11 months ago by mmocny
Modified:
8 years, 9 months ago
CC:
chromium-reviews, jonathan.backer, Ian Vollick, dhollowa+watch_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Replace WGC3D visibility extension with resource_usage extension. [Part 2 of 3] This is the second of a three part patch (WebKit, Chromium, Webkit-Touchups) to replace the WebGraphicsContext3D setVisibility extension with a setResourceUsage extension that is both more accurate and more flexible. This change is a prereq for some other work on reducing resource usage of background tabs in certain scenarios. BUG=None TEST=Manual

Patch Set 1 : Clarifying a comment #

Total comments: 1

Patch Set 2 : Added image_transport_surface_win changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -58 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_linux.cc View 1 4 chunks +29 lines, -14 lines 0 comments Download
M content/common/gpu/image_transport_surface_win.cc View 1 2 chunks +16 lines, -11 lines 0 comments Download
M content/renderer/gpu/command_buffer_proxy.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/gpu/command_buffer_proxy.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 1 chunk +14 lines, -5 lines 0 comments Download
M ui/gfx/compositor/test_web_graphics_context_3d.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface.h View 2 chunks +9 lines, -2 lines 0 comments Download
M ui/gfx/gl/gl_surface.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mmocny
Part 1(webkit patch) is https://bugs.webkit.org/show_bug.cgi?id=76634. Ken, Al has been more in the loop with my ...
8 years, 11 months ago (2012-01-19 15:46:43 UTC) #1
jonathan.backer
http://codereview.chromium.org/9192014/diff/3001/ui/gfx/gl/gl_surface.h File ui/gfx/gl/gl_surface.h (right): http://codereview.chromium.org/9192014/diff/3001/ui/gfx/gl/gl_surface.h#newcode83 ui/gfx/gl/gl_surface.h:83: virtual void SetResourceUsage(ResourceUsage resourceUsage); A lot has changed since ...
8 years, 11 months ago (2012-01-19 16:11:19 UTC) #2
mmocny
This is excellent. I will make the change. On 2012/01/19 16:11:19, jonathan.backer wrote: > http://codereview.chromium.org/9192014/diff/3001/ui/gfx/gl/gl_surface.h ...
8 years, 11 months ago (2012-01-19 16:14:07 UTC) #3
mmocny
An ImageTransportSurface is not itself a GLSurface, and changing GpuCommandBufferStub to using an ImageTransportSurface was ...
8 years, 11 months ago (2012-01-19 17:40:08 UTC) #4
Ken Russell (switch to Gerrit)
8 years, 11 months ago (2012-01-19 18:31:19 UTC) #5
This seems fine to me. Since it has to wait for the webkit patch to land and
DEPS rolled forward, please send try jobs and ask for re-review once that's
done.

Powered by Google App Engine
This is Rietveld 408576698