net/dns/dns_response_unittest.cc - Issue 9190031: DnsClient refactoring + features (timeout, suffix search, server rotation).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/dns_response_unittest.cc

Issue 9190031: DnsClient refactoring + features (timeout, suffix search, server rotation). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added comments. Fixed tests. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/dns_response_unittest.cc

diff --git a/net/dns/dns_response_unittest.cc b/net/dns/dns_response_unittest.cc

index 51d7cffd47400b15f67bfa9d5858fa8b4488ba87..3644703c1b9b83ea7e46295c1476babbff4808cd 100644

--- a/net/dns/dns_response_unittest.cc

+++ b/net/dns/dns_response_unittest.cc

@@ -219,8 +219,7 @@ TEST(DnsResponseTest, InitParse) {

EXPECT_TRUE(resp.InitParse(sizeof(response_data), *query));

// Check header access.

- EXPECT_EQ(0x81, resp.flags0());

- EXPECT_EQ(0x80, resp.flags1());

+ EXPECT_EQ(0x8180, resp.flags());

mmenke 2012/01/13 16:44:37 I assume you planned to do so already, but just in

EXPECT_EQ(0x0, resp.rcode());

EXPECT_EQ(2, resp.answer_count());

« net/dns/dns_response.cc ('K') | « net/dns/dns_response.cc ('k') | net/dns/dns_session.h » ('j') | net/net.gyp » ('J')