DnsClient refactoring + features (timeout, suffix search, server rotation).

net/dns/dns_response_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_response.h"
 
 #include "net/base/io_buffer.h"
 #include "net/dns/dns_protocol.h"
 #include "net/dns/dns_query.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 201 matching lines @@
 
   // Reject wrong question.
   scoped_ptr<DnsQuery> wrong_query(
       new DnsQuery(0xcafe, qname, dns_protocol::kTypeCNAME));
   EXPECT_FALSE(resp.InitParse(sizeof(response_data), *wrong_query));
 
   // Accept matching question.
   EXPECT_TRUE(resp.InitParse(sizeof(response_data), *query));
 
   // Check header access.
-  EXPECT_EQ(0x81, resp.flags0());
-  EXPECT_EQ(0x80, resp.flags1());
+  EXPECT_EQ(0x8180, resp.flags());

[mmenke, 2012/01/13 16:44:37]

I assume you planned to do so already, but just in case it didn't occur to you,
should add tests for new qname, qtype, and GetDottedName functions in this file.

   EXPECT_EQ(0x0, resp.rcode());
   EXPECT_EQ(2, resp.answer_count());
 
   DnsResourceRecord record;
   DnsRecordParser parser = resp.Parser();
   EXPECT_TRUE(parser.ParseRecord(&record));
   EXPECT_TRUE(parser.ParseRecord(&record));
   EXPECT_FALSE(parser.ParseRecord(&record));
 }
 
 }  // namespace
 
 }  // namespace net