Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2943)

Unified Diff: runtime/platform/assert.cc

Issue 9189003: Move assert.h/assert.cc from runtime/vm to runtime/platform (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixing vm/assert.h for _macos, _win, _arm and _x64 files Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/platform/assert.cc
diff --git a/runtime/vm/assert.cc b/runtime/platform/assert.cc
similarity index 91%
rename from runtime/vm/assert.cc
rename to runtime/platform/assert.cc
index ecda4d12b8fe744f529564a656a0f6d93d97a2a0..2f3e145e47b31018ab9cefc124b2597f1a506544 100644
--- a/runtime/vm/assert.cc
+++ b/runtime/platform/assert.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -6,7 +6,8 @@
#include <sstream>
#include <string>
-#include "vm/assert.h"
+#include "platform/assert.h"
+#include "vm/globals.h"
Mads Ager (chromium) 2012/01/13 14:42:08 What is this needed for? Maybe that part of vm/glo
Ivan Posva 2012/01/13 23:22:06 Agree, should it be allowed to access "vm/*" heade
Søren Gjesse 2012/01/16 08:58:00 Yes it should. This is actually done in http://cod
Søren Gjesse 2012/01/16 08:58:00 Absolutely - there should be no references from pl
namespace dart {

Powered by Google App Engine
This is Rietveld 408576698