Move assert.h/assert.cc from runtime/vm to runtime/platform

runtime/platform/assert.cc

-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <cstdlib>
 #include <sstream>
 #include <string>
 
-#include "vm/assert.h"
+#include "platform/assert.h"
+#include "vm/globals.h"

[Mads Ager (chromium), 2012/01/13 14:42:08]

What is this needed for? Maybe that part of vm/globals.h should be moved to
platform/globals.h?

[Ivan Posva, 2012/01/13 23:22:06]

Agree, should it be allowed to access "vm/*" headers from platform code?

[Søren Gjesse, 2012/01/16 08:58:00]

Yes it should. This is actually done in http://codereview.chromium.org/9209001/,
so I will make the change from vm/globals.h to platform/globals.h as part of
that change.

[Søren Gjesse, 2012/01/16 08:58:00]

Absolutely - there should be no references from platform/ to vm/. See comment
above.

 
 namespace dart {
 
 // Exit with a failure code when we miss an EXPECT check.
 static void failed_exit(void) {
   exit(255);
 }
 
 void DynamicAssertionHelper::Fail(const char* format, ...) {
   std::stringstream stream;
@@ skipping 19 matching lines @@
     std::abort();
   }
   static bool failed = false;
   if (!failed) {
     std::atexit(&failed_exit);
   }
   failed = true;
 }
 
 }  // namespace dart