Move assert.h/assert.cc from runtime/vm to runtime/platform

Move assert.h/assert.cc from runtime/vm to runtime/platform

The purpose of this change is twofold:

1. Source in the bin directory can now use the same assertions as
   source in the vm directory. The ASSERT macro used by the code
   in runtime/bin was just defined to use assert from the standard
   C library.
2. Moving other implementation parts from runtime/vm to
   runtime/platform (e.g. classes Monitor and Mutex) for sharing
   between runtime/bin and runtime/vm will be easier as these
   implementations rely on these assertion macros.

Created two gypi files for the platform directory. One for the
headers and one for the source. The source one is only included
when building the VM library and will be present in libdart.a
when the dart executable is linked.

All the code for asserts is still in the dart namespace.

Also re-arranged the order of includes to be alphabetically in
the files touched.

R=ager@google.com, iposva@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3335

[Mads Ager (chromium), 2012-01-13 14:42:05]

Some of the reordering of headers should be undone to always include the header
file you are implementing as the first thing in the cc files.

http://codereview.chromium.org/9189003/diff/2002/runtime/platform/assert.cc
File runtime/platform/assert.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/platform/assert.cc#n...
runtime/platform/assert.cc:10: #include "vm/globals.h"
What is this needed for? Maybe that part of vm/globals.h should be moved to
platform/globals.h?

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/bigint_store.h
File runtime/vm/bigint_store.h (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/bigint_store.h#ne...
runtime/vm/bigint_store.h:9: #include "vm/isolate.h"
Has something changed here? I don't see vm/globals.h changed, so I'm not sure I
understand why this one has to change?

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/native_arguments.cc
File runtime/vm/native_arguments.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/native_arguments....
runtime/vm/native_arguments.cc:6: #include "vm/globals.h"
Why is globals.h needed here?

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/scanner.cc
File runtime/vm/scanner.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/scanner.cc#newcode8
runtime/vm/scanner.cc:8: #include "vm/scanner.h"
I don't think you should move this one down. This is the implementation of
scanner.h. We usually put those includes first.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...

I haven't doubled checked the other cc files. Could you do that?

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/snapshot.cc#newco...
runtime/vm/snapshot.cc:10: #include "vm/snapshot.h"
Move this back up since this is the header file this is implementing.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/store_buffer.cc
File runtime/vm/store_buffer.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/store_buffer.cc#n...
runtime/vm/store_buffer.cc:6: #include "vm/store_buffer.h"
Here as well.

[Ivan Posva, 2012-01-13 23:22:06]

Please restore the header order according to

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...

including the empty line between implemented header and the rest of the project
headers. Thank you!

-Ivan

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/directory.cc#new...
runtime/bin/directory.cc:1: // Copyright (c) 2011, the Dart project authors. 
Please see the AUTHORS file
2012, maybe others...

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/directory.cc#new...
runtime/bin/directory.cc:6: #include "bin/directory.h"
Should bin/directory.h be first when being included from bin/directory.cc?

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/file_linux.cc
File runtime/bin/file_linux.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/file_linux.cc#ne...
runtime/bin/file_linux.cc:12: #include "bin/file.h"
file.h first as this is really the file.cc

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/file_macos.cc
File runtime/bin/file_macos.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/file_macos.cc#ne...
runtime/bin/file_macos.cc:13: #include "bin/file.h"
ditto.

http://codereview.chromium.org/9189003/diff/2002/runtime/platform/assert.cc
File runtime/platform/assert.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/platform/assert.cc#n...
runtime/platform/assert.cc:10: #include "vm/globals.h"
On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> What is this needed for? Maybe that part of vm/globals.h should be moved to
> platform/globals.h?

Agree, should it be allowed to access "vm/*" headers from platform code?

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/allocation.cc
File runtime/vm/allocation.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/allocation.cc#new...
runtime/vm/allocation.cc:6: #include "vm/allocation.h"
first, and many others.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/disassembler_arm.cc
File runtime/vm/disassembler_arm.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/disassembler_arm....
runtime/vm/disassembler_arm.cc:9: #include "vm/disassembler.h"
First? It is the moral equivalent of disassembler_arm.cc, no?

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/disassembler_x64.cc
File runtime/vm/disassembler_x64.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/disassembler_x64....
runtime/vm/disassembler_x64.cc:16: #include "vm/disassembler.h"
ditto

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/flags.cc
File runtime/vm/flags.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/flags.cc#newcode6
runtime/vm/flags.cc:6: #include "vm/flags.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/handles.cc
File runtime/vm/handles.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/handles.cc#newcode6
runtime/vm/handles.cc:6: #include "vm/handles.h"
First.

Also I find it helpful if the special first include is set off by one line.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/heap.cc#newcode8
runtime/vm/heap.cc:8: #include "vm/heap.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/isolate.cc#newcode16
runtime/vm/isolate.cc:16: #include "vm/isolate.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/native_arguments.cc
File runtime/vm/native_arguments.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/native_arguments....
runtime/vm/native_arguments.cc:7: #include "vm/native_arguments.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/object.cc#newcode22
runtime/vm/object.cc:22: #include "vm/object.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/os_win.cc
File runtime/vm/os_win.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/os_win.cc#newcode8
runtime/vm/os_win.cc:8: #include "vm/os.h"
First. os_win.cc is essentially os.cc.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/pages.cc#newcode9
runtime/vm/pages.cc:9: #include "vm/pages.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/random.cc
File runtime/vm/random.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/random.cc#newcode7
runtime/vm/random.cc:7: #include "vm/random.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/scanner.cc
File runtime/vm/scanner.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/scanner.cc#newcode8
runtime/vm/scanner.cc:8: #include "vm/scanner.h"
On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> I don't think you should move this one down. This is the implementation of
> scanner.h. We usually put those includes first.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...
> 
> I haven't doubled checked the other cc files. Could you do that?

I agree, there quite a few files that broke the include order.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/stub_code.cc
File runtime/vm/stub_code.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/stub_code.cc#newc...
runtime/vm/stub_code.cc:9: #include "vm/stub_code.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_linux.cc
File runtime/vm/thread_linux.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_linux.cc#n...
runtime/vm/thread_linux.cc:9: #include "vm/thread.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_macos.cc
File runtime/vm/thread_macos.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_macos.cc#n...
runtime/vm/thread_macos.cc:8: #include "vm/thread.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_win.cc
File runtime/vm/thread_win.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_win.cc#new...
runtime/vm/thread_win.cc:8: #include "vm/thread.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/verifier.cc
File runtime/vm/verifier.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/verifier.cc#newco...
runtime/vm/verifier.cc:14: #include "vm/verifier.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory.cc
File runtime/vm/virtual_memory.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory.cc...
runtime/vm/virtual_memory.cc:7: #include "vm/virtual_memory.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_li...
File runtime/vm/virtual_memory_linux.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_li...
runtime/vm/virtual_memory_linux.cc:11: #include "vm/virtual_memory.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_ma...
File runtime/vm/virtual_memory_macos.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_ma...
runtime/vm/virtual_memory_macos.cc:10: #include "vm/virtual_memory.h"
.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_wi...
File runtime/vm/virtual_memory_win.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_wi...
runtime/vm/virtual_memory_win.cc:6: #include "vm/virtual_memory.h"
First.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/zone.cc
File runtime/vm/zone.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/zone.cc#newcode10
runtime/vm/zone.cc:10: #include "vm/zone.h"
First.

[Søren Gjesse, 2012-01-16 08:58:00]

Thanks for looking at all these files.

I am sorry about the include file ordering mistakes - I was not aware of the
special rule for the implemented header in
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Names_....

It has not been fixed in all modified files.

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/directory.cc
File runtime/bin/directory.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/directory.cc#new...
runtime/bin/directory.cc:1: // Copyright (c) 2011, the Dart project authors. 
Please see the AUTHORS file
On 2012/01/13 23:22:06, Ivan Posva wrote:
> 2012, maybe others...

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/directory.cc#new...
runtime/bin/directory.cc:6: #include "bin/directory.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> Should bin/directory.h be first when being included from bin/directory.cc?

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/file_linux.cc
File runtime/bin/file_linux.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/file_linux.cc#ne...
runtime/bin/file_linux.cc:12: #include "bin/file.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> file.h first as this is really the file.cc

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/file_macos.cc
File runtime/bin/file_macos.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/bin/file_macos.cc#ne...
runtime/bin/file_macos.cc:13: #include "bin/file.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> ditto.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/platform/assert.cc
File runtime/platform/assert.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/platform/assert.cc#n...
runtime/platform/assert.cc:10: #include "vm/globals.h"
On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> What is this needed for? Maybe that part of vm/globals.h should be moved to
> platform/globals.h?

Yes it should. This is actually done in http://codereview.chromium.org/9209001/,
so I will make the change from vm/globals.h to platform/globals.h as part of
that change.

http://codereview.chromium.org/9189003/diff/2002/runtime/platform/assert.cc#n...
runtime/platform/assert.cc:10: #include "vm/globals.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> > What is this needed for? Maybe that part of vm/globals.h should be moved to
> > platform/globals.h?
> 
> Agree, should it be allowed to access "vm/*" headers from platform code?

Absolutely - there should be no references from platform/ to vm/. See comment
above.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/allocation.cc
File runtime/vm/allocation.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/allocation.cc#new...
runtime/vm/allocation.cc:6: #include "vm/allocation.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> first, and many others.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/bigint_store.h
File runtime/vm/bigint_store.h (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/bigint_store.h#ne...
runtime/vm/bigint_store.h:9: #include "vm/isolate.h"
On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> Has something changed here? I don't see vm/globals.h changed, so I'm not sure
I
> understand why this one has to change?

No, reverted.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/disassembler_arm.cc
File runtime/vm/disassembler_arm.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/disassembler_arm....
runtime/vm/disassembler_arm.cc:9: #include "vm/disassembler.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First? It is the moral equivalent of disassembler_arm.cc, no?

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/disassembler_x64.cc
File runtime/vm/disassembler_x64.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/disassembler_x64....
runtime/vm/disassembler_x64.cc:16: #include "vm/disassembler.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> ditto

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/flags.cc
File runtime/vm/flags.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/flags.cc#newcode6
runtime/vm/flags.cc:6: #include "vm/flags.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/handles.cc
File runtime/vm/handles.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/handles.cc#newcode6
runtime/vm/handles.cc:6: #include "vm/handles.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.
> 
> Also I find it helpful if the special first include is set off by one line.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/heap.cc#newcode8
runtime/vm/heap.cc:8: #include "vm/heap.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/isolate.cc#newcode16
runtime/vm/isolate.cc:16: #include "vm/isolate.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/native_arguments.cc
File runtime/vm/native_arguments.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/native_arguments....
runtime/vm/native_arguments.cc:6: #include "vm/globals.h"
On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> Why is globals.h needed here?

vm/assert.h used to include vm/globals.h. It vas actually needed in
natives_arguments.h, so moved it there instead.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/native_arguments....
runtime/vm/native_arguments.cc:7: #include "vm/native_arguments.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/object.cc#newcode22
runtime/vm/object.cc:22: #include "vm/object.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/os_win.cc
File runtime/vm/os_win.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/os_win.cc#newcode8
runtime/vm/os_win.cc:8: #include "vm/os.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First. os_win.cc is essentially os.cc.

Done. Did the same for os_linux and os_macos.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/pages.cc#newcode9
runtime/vm/pages.cc:9: #include "vm/pages.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/random.cc
File runtime/vm/random.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/random.cc#newcode7
runtime/vm/random.cc:7: #include "vm/random.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/scanner.cc
File runtime/vm/scanner.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/scanner.cc#newcode8
runtime/vm/scanner.cc:8: #include "vm/scanner.h"
On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> I don't think you should move this one down. This is the implementation of
> scanner.h. We usually put those includes first.
> 
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...
> 
> I haven't doubled checked the other cc files. Could you do that?

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/scanner.cc#newcode8
runtime/vm/scanner.cc:8: #include "vm/scanner.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> > I don't think you should move this one down. This is the implementation of
> > scanner.h. We usually put those includes first.
> > 
> >
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Names_and_Orde...
> > 
> > I haven't doubled checked the other cc files. Could you do that?
> 
> I agree, there quite a few files that broke the include order.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/snapshot.cc#newco...
runtime/vm/snapshot.cc:10: #include "vm/snapshot.h"
On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> Move this back up since this is the header file this is implementing.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/store_buffer.cc
File runtime/vm/store_buffer.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/store_buffer.cc#n...
runtime/vm/store_buffer.cc:6: #include "vm/store_buffer.h"
On 2012/01/13 14:42:08, Mads Sig Ager wrote:
> Here as well.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/stub_code.cc
File runtime/vm/stub_code.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/stub_code.cc#newc...
runtime/vm/stub_code.cc:9: #include "vm/stub_code.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_linux.cc
File runtime/vm/thread_linux.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_linux.cc#n...
runtime/vm/thread_linux.cc:9: #include "vm/thread.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_macos.cc
File runtime/vm/thread_macos.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_macos.cc#n...
runtime/vm/thread_macos.cc:8: #include "vm/thread.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_win.cc
File runtime/vm/thread_win.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/thread_win.cc#new...
runtime/vm/thread_win.cc:8: #include "vm/thread.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/verifier.cc
File runtime/vm/verifier.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/verifier.cc#newco...
runtime/vm/verifier.cc:14: #include "vm/verifier.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory.cc
File runtime/vm/virtual_memory.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory.cc...
runtime/vm/virtual_memory.cc:7: #include "vm/virtual_memory.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_li...
File runtime/vm/virtual_memory_linux.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_li...
runtime/vm/virtual_memory_linux.cc:11: #include "vm/virtual_memory.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_ma...
File runtime/vm/virtual_memory_macos.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_ma...
runtime/vm/virtual_memory_macos.cc:10: #include "vm/virtual_memory.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> .

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_wi...
File runtime/vm/virtual_memory_win.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/virtual_memory_wi...
runtime/vm/virtual_memory_win.cc:6: #include "vm/virtual_memory.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/zone.cc
File runtime/vm/zone.cc (right):

http://codereview.chromium.org/9189003/diff/2002/runtime/vm/zone.cc#newcode10
runtime/vm/zone.cc:10: #include "vm/zone.h"
On 2012/01/13 23:22:06, Ivan Posva wrote:
> First.

Done.

[Mads Ager (google), 2012-01-16 10:20:05]

lgtm

http://codereview.chromium.org/9189003/diff/16001/runtime/platform/assert.h
File runtime/platform/assert.h (right):

http://codereview.chromium.org/9189003/diff/16001/runtime/platform/assert.h#n...
runtime/platform/assert.h:1: // Copyright (c) 2011, the Dart project authors. 
Please see the AUTHORS file
2012

http://codereview.chromium.org/9189003/diff/16001/runtime/vm/boolfield_test.cc
File runtime/vm/boolfield_test.cc (right):

http://codereview.chromium.org/9189003/diff/16001/runtime/vm/boolfield_test.c...
runtime/vm/boolfield_test.cc:6: #include "vm/globals.h"
I don't really see anything in this file that uses globals.h?

[Søren Gjesse, 2012-01-16 11:56:44]

http://codereview.chromium.org/9189003/diff/16001/runtime/platform/assert.h
File runtime/platform/assert.h (right):

http://codereview.chromium.org/9189003/diff/16001/runtime/platform/assert.h#n...
runtime/platform/assert.h:1: // Copyright (c) 2011, the Dart project authors. 
Please see the AUTHORS file
On 2012/01/16 10:20:05, Mads Ager wrote:
> 2012

Done.

http://codereview.chromium.org/9189003/diff/16001/runtime/vm/boolfield_test.cc
File runtime/vm/boolfield_test.cc (right):

http://codereview.chromium.org/9189003/diff/16001/runtime/vm/boolfield_test.c...
runtime/vm/boolfield_test.cc:6: #include "vm/globals.h"
On 2012/01/16 10:20:05, Mads Ager wrote:
> I don't really see anything in this file that uses globals.h? 

It is needed by boolfield.h (type uword). Moved it there.