Cleanup: Rename is_hsts_host to fatal.

net/url_request/url_request.h

Index: net/url_request/url_request.h
===================================================================
--- net/url_request/url_request.h	(revision 117302)
+++ net/url_request/url_request.h	(working copy)
@@ -262,12 +262,13 @@
     // safe thing and Cancel() the request or decide to proceed by calling
     // ContinueDespiteLastError().  cert_error is a ERR_* error code
     // indicating what's wrong with the certificate.
-    // If |is_hsts_host| is true then the host in question is an HSTS host
-    // which demands a higher level of security. In this case, errors must not
-    // be bypassable by the user.
+    // If |overridable| is true then the host in question is a host which
+    // demands a higher level of security (due e.g. to HTTP Strict Transport
+    // Security, user preference, or built-in policy). In this case, errors
+    // must not be bypassable by the user.

[michaeln, 2012/01/12 20:39:33]

Is the polarity of the new argument reversed?

if (overridable)
   "must not be bypassable by the user"

[wtc, 2012/01/13 01:39:57]

Yes, 'fatal' is more appropriate than 'overridable'.

     virtual void OnSSLCertificateError(URLRequest* request,
                                        const SSLInfo& ssl_info,
-                                       bool is_hsts_host);
+                                       bool overridable);
 
     // Called when reading cookies to allow the delegate to block access to the
     // cookie. This method will never be invoked when LOAD_DO_NOT_SEND_COOKIES
@@ -705,7 +706,7 @@
   void NotifyAuthRequiredComplete(NetworkDelegate::AuthRequiredResponse result);
   void NotifyCertificateRequested(SSLCertRequestInfo* cert_request_info);
   void NotifySSLCertificateError(const SSLInfo& ssl_info,
-                                 bool is_hsts_host);
+                                 bool overridable);
   bool CanGetCookies(const CookieList& cookie_list) const;
   bool CanSetCookie(const std::string& cookie_line,
                     CookieOptions* options) const;