Cleanup: Rename is_hsts_host to fatal.

net/url_request/url_request.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_H_
 #define NET_URL_REQUEST_URL_REQUEST_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 244 matching lines @@
     virtual void OnCertificateRequested(
         URLRequest* request,
         SSLCertRequestInfo* cert_request_info);
 
     // Called when using SSL and the server responds with a certificate with
     // an error, for example, whose common name does not match the common name
     // we were expecting for that host.  The delegate should either do the
     // safe thing and Cancel() the request or decide to proceed by calling
     // ContinueDespiteLastError().  cert_error is a ERR_* error code
     // indicating what's wrong with the certificate.
-    // If |is_hsts_host| is true then the host in question is an HSTS host
-    // which demands a higher level of security. In this case, errors must not
-    // be bypassable by the user.
+    // If |overridable| is true then the host in question is a host which
+    // demands a higher level of security (due e.g. to HTTP Strict Transport
+    // Security, user preference, or built-in policy). In this case, errors
+    // must not be bypassable by the user.

[michaeln, 2012/01/12 20:39:33]

Is the polarity of the new argument reversed?

if (overridable)
   "must not be bypassable by the user"

[wtc, 2012/01/13 01:39:57]

Yes, 'fatal' is more appropriate than 'overridable'.

     virtual void OnSSLCertificateError(URLRequest* request,
                                        const SSLInfo& ssl_info,
-                                       bool is_hsts_host);
+                                       bool overridable);
 
     // Called when reading cookies to allow the delegate to block access to the
     // cookie. This method will never be invoked when LOAD_DO_NOT_SEND_COOKIES
     // is specified.
     virtual bool CanGetCookies(const URLRequest* request,
                                const CookieList& cookie_list) const;
 
     // Called when a cookie is set to allow the delegate to block access to the
     // cookie. This method will never be invoked when LOAD_DO_NOT_SAVE_COOKIES
     // is specified.
@@ skipping 417 matching lines @@
 
   bool has_delegate() const { return delegate_ != NULL; }
 
   // These functions delegate to |delegate_| and may only be used if
   // |delegate_| is not NULL. See URLRequest::Delegate for the meaning
   // of these functions.
   void NotifyAuthRequired(AuthChallengeInfo* auth_info);
   void NotifyAuthRequiredComplete(NetworkDelegate::AuthRequiredResponse result);
   void NotifyCertificateRequested(SSLCertRequestInfo* cert_request_info);
   void NotifySSLCertificateError(const SSLInfo& ssl_info,
-                                 bool is_hsts_host);
+                                 bool overridable);
   bool CanGetCookies(const CookieList& cookie_list) const;
   bool CanSetCookie(const std::string& cookie_line,
                     CookieOptions* options) const;
   void NotifyReadCompleted(int bytes_read);
 
   // Called when the delegate blocks or unblocks this request when intercepting
   // certain requests.
   void SetBlockedOnDelegate();
   void SetUnblockedOnDelegate();
 
@@ skipping 84 matching lines @@
   scoped_refptr<AuthChallengeInfo> auth_info_;
 
   base::TimeTicks creation_time_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequest);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_H_