Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9188012: bots: include webdriver tests in bots. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index f9878213ea734860798fdfe20a016170f90d4bc6..da0aa53b148a0a250b18026e28d4f9da052073ae 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -463,27 +463,7 @@ class StandardTestSuite implements TestSuite {
List<String> args;
if (component == 'webdriver') {
executable = '$dartDir/tools/testing/run_selenium.py';
- String browserFlag = 'chrome';
- if (configuration['flag'] != null) {
- for (var flag in configuration['flag'].split(',')) {
- switch (flag) {
- case 'ff':
- case 'firefox':
- browserFlag = 'ff';
- break;
- case 'ie':
- case 'explorer':
- case 'internet-explorer':
- browserFlag = 'ie';
- break;
- case 'safari':
- browserFlag = 'safari';
- break;
- }
- }
- }
- args = ['--out', htmlPath, '--browser', browserFlag];
-
+ args = ['--out', htmlPath, '--browser', configuration['browser']];
Emily Fortuna 2012/01/11 18:59:45 What if the browser flag isn't specified? Previous
Siggi Cherem (dart-lang) 2012/01/11 19:55:22 Turns out I made the 'browser' flag in test_option
Emily Fortuna 2012/01/11 20:29:06 Gotcha! I forgot about that. Carry on. On 2012/01
} else {
args = ['--no-timeout'];
if (component == 'dartium') {

Powered by Google App Engine
This is Rietveld 408576698