bots: include webdriver tests in bots.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_suite");
 
 #import("status_file_parser.dart");
 #import("test_runner.dart");
 #import("multitest.dart");
 
@@ skipping 445 matching lines @@
           compilerArgs = null;
           break;
         default:
           Expect.fail('unimplemented component $component');
       }
 
       String executable = getFilename(dumpRenderTreeFilename);
       List<String> args;
       if (component == 'webdriver') {
         executable = '$dartDir/tools/testing/run_selenium.py';
-        String browserFlag = 'chrome';
-        if (configuration['flag'] != null) {
-          for (var flag in configuration['flag'].split(',')) {
-            switch (flag) {
-              case 'ff':
-              case 'firefox':
-                browserFlag = 'ff';
-                break;
-              case 'ie':
-              case 'explorer':
-              case 'internet-explorer':
-                browserFlag = 'ie';
-                break;
-              case 'safari':
-                browserFlag = 'safari';
-                break;
-            }
-          }
-        }
-        args = ['--out', htmlPath, '--browser', browserFlag];
-
+        args = ['--out', htmlPath, '--browser', configuration['browser']];

[Emily Fortuna, 2012/01/11 18:59:45]

What if the browser flag isn't specified? Previously, we defaulted to chrome if
we specified webdriver without a flag. But throwing an error is also valid. 

[Siggi Cherem (dart-lang), 2012/01/11 19:55:22]

Turns out I made the 'browser' flag in test_options.dart have 'chrome' as the
default.

[Emily Fortuna, 2012/01/11 20:29:06]

Gotcha! I forgot about that. Carry on.

On 2012/01/11 19:55:22, sigmund wrote:

       } else {
         args = ['--no-timeout'];
         if (component == 'dartium') {
           var dartFlags = ['--enable_asserts',
                            '--enable_type_checks',
                            '--ignore-unrecognized-flags'];
           dartFlags.addAll(vmOptions);
           args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
         }
         args.add(htmlPath);
@@ skipping 535 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout\
 """;
     print(report);
   }
 }