Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 9185026: Convert use of int ms to TimeDelta in files owned by brettw. (Closed)

Created:
8 years, 11 months ago by Ted Vessenes
Modified:
8 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, sadrul, tfarina, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Convert use of int ms to TimeDelta in files owned by brettw. R=brettw@chromium.org BUG=108171 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117824

Patch Set 1 #

Patch Set 2 : Remove static class initializations. #

Total comments: 2

Patch Set 3 : Remove another static class instance initialization. #

Patch Set 4 : Explicitly include base/time.h in header file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -114 lines) Patch
M base/message_loop_proxy_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/timer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/google/google_url_tracker.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/history/redirect_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/text_database_manager.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/images_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intranet_redirect_detector.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_uitest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/web_cache_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 3 3 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/translate/translate_manager.h View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/unload_uitest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_unittest.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/important_file_writer_unittest.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/common/profiling.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/worker_thread_ticker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/worker_thread_ticker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/worker_thread_ticker_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/renderer/about_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/user_script_idle_scheduler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/net/renderer_net_predictor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/translate_helper.cc View 1 4 chunks +13 lines, -7 lines 0 comments Download
M content/browser/browser_child_process_host.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_channel.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/ppapi_plugin/broker_process_dispatcher.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/ppapi_plugin/plugin_process_dispatcher.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/load_progress_tracker.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M dbus/test_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted Vessenes
8 years, 11 months ago (2012-01-11 22:04:45 UTC) #1
brettw
lgtm http://codereview.chromium.org/9185026/diff/3001/chrome/browser/task_manager/task_manager.cc File chrome/browser/task_manager/task_manager.cc (right): http://codereview.chromium.org/9185026/diff/3001/chrome/browser/task_manager/task_manager.cc#newcode50 chrome/browser/task_manager/task_manager.cc:50: using base::TimeDelta; It's not clear why you did ...
8 years, 11 months ago (2012-01-15 17:28:11 UTC) #2
Ted Vessenes
I think I just missed that instance when I converted the other files. Made the ...
8 years, 11 months ago (2012-01-15 21:22:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9185026/7002
8 years, 11 months ago (2012-01-15 21:22:18 UTC) #4
commit-bot: I haz the power
Try job failure for 9185026-7002 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-15 22:31:16 UTC) #5
Ted Vessenes
Correct me if I'm wrong, but I think this is just a flaky test? The ...
8 years, 11 months ago (2012-01-15 22:59:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9185026/7002
8 years, 11 months ago (2012-01-15 23:00:08 UTC) #7
commit-bot: I haz the power
8 years, 11 months ago (2012-01-16 01:46:30 UTC) #8
Change committed as 117824

Powered by Google App Engine
This is Rietveld 408576698