Remove the type token used to pass element information to arrays.

Remove TypeToken as means for assigning type arguments to arrays.

For native, classes with a bodyless constructor, pass the constructor arguments to the native constructor in the generated factory method.  The generated factory method will handle setting the runtime type information if necessary.

Committed: https://code.google.com/p/dart/source/detail?r=3356

[mmendez, 2012-01-13 16:28:00]

Previously we always created a TypeToken instance to pass type arguments to
ListImplementation instances.  Because of this the native code was aware of the
type arguments and it was making it harder to elide runtime type information
when it is not used by the program.

[floitsch, 2012-01-16 13:23:26]

With the exception of the part that I don't understand lgtm.
Please clarify and I will have another look.

http://codereview.chromium.org/9183002/diff/1/compiler/java/com/google/dart/c...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/9183002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1063:
if (classElement.getNativeName() != null && x.getFunction().getBody() == null) {
I don't understand this code. (In any case add comments).

[mmendez, 2012-01-17 12:48:04]

PTAL

http://codereview.chromium.org/9183002/diff/1/compiler/java/com/google/dart/c...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/9183002/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1063:
if (classElement.getNativeName() != null && x.getFunction().getBody() == null) {
Added a comment in the code to match the comment in the code review description.

For native classes that declare a body-less constructor, we will pass the
factory arguments to the native "new" expression.

In this case, it causes the length of the array to be passed to the "new
Array..." JS expression being generated which allows us to use the generated
factory method for instantiating the native class as well as optionally adding
the runtime type information if necessary without a temporary object.
 
On 2012/01/16 13:23:26, floitsch wrote:
> I don't understand this code. (In any case add comments).

[floitsch, 2012-01-17 14:25:18]

LGTM.