[uber page] Migrate remaining Personal options into Browser options.

[uber page] Migrate remaining Personal options into Browser options.

- Move UI and backing code for account (cros), themes, import data.
- Move some code for the sync section that was missed in a previous migration.
- Minor reorganizations to match mocks.

BUG=107468, 107484
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117299

[csilv, 2012-01-11 02:22:15]

+jhawkins for review

Sorry about the size of this one... it's mostly copy/paste/delete, but there's
just a lot of it.  See my email for some additional details.

[James Hawkins, 2012-01-11 16:33:29]

http://codereview.chromium.org/9181013/diff/2002/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/9181013/diff/2002/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:8583: <message
name="IDS_APPEARANCE_GROUP_NAME" desc="In Title Case: The title of the
appearance group">
Why do we need a title case version for one word?

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
File chrome/browser/resources/options2/browser_options.html (right):

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
chrome/browser/resources/options2/browser_options.html:61: <h3
i18n-content="appearance"></h3>
I don't understand this change: I changed toolbarGroupName to match the mock,
which calls for "Toolbar Appearance".

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
File chrome/browser/resources/options2/browser_options.js (right):

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
chrome/browser/resources/options2/browser_options.js:17: if (cr.isChromeOS) {
Can this not be done in initializePage()?

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
chrome/browser/resources/options2/browser_options.js:73: // Appearance section.
Toolbar Appearance

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
chrome/browser/resources/options2/browser_options.js:566:
BrowserOptions.getLoggedInUsername = function() {
Ugh, this smells to me.  I'm not going to ask you to investigate though.  Can
you add a TODO(jhawkins) to look into it?

[csilv, 2012-01-11 18:47:08]

http://codereview.chromium.org/9181013/diff/2002/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/9181013/diff/2002/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:8583: <message
name="IDS_APPEARANCE_GROUP_NAME" desc="In Title Case: The title of the
appearance group">
On 2012/01/11 16:33:29, James Hawkins wrote:
> Why do we need a title case version for one word?

We don't for English, but we may for other languages where the translation may
be more than a single word.

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
File chrome/browser/resources/options2/browser_options.html (right):

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
chrome/browser/resources/options2/browser_options.html:61: <h3
i18n-content="appearance"></h3>
On 2012/01/11 16:33:29, James Hawkins wrote:
> I don't understand this change: I changed toolbarGroupName to match the mock,
> which calls for "Toolbar Appearance".

The 'Chrome Settings Structure' document uses 'Appearance'. In the cases where
the document conflicts with the mock, I've been using the wording in the mock. 
'Appearance' probably makes more sense here since themes are not specific to the
toolbar.

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
File chrome/browser/resources/options2/browser_options.js (right):

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
chrome/browser/resources/options2/browser_options.js:17: if (cr.isChromeOS) {
On 2012/01/11 16:33:29, James Hawkins wrote:
> Can this not be done in initializePage()?

Done.

http://codereview.chromium.org/9181013/diff/2002/chrome/browser/resources/opt...
chrome/browser/resources/options2/browser_options.js:566:
BrowserOptions.getLoggedInUsername = function() {
On 2012/01/11 16:33:29, James Hawkins wrote:
> Ugh, this smells to me.  I'm not going to ask you to investigate though.  Can
> you add a TODO(jhawkins) to look into it?

Done.

[James Hawkins, 2012-01-11 19:02:21]

lgtm

[commit-bot: I haz the power, 2012-01-11 19:15:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csilv@chromium.org/9181013/9001

[commit-bot: I haz the power, 2012-01-11 19:15:52]

Can't apply patch for file
chrome/browser/resources/options2/browser_options_profile_list.js.
While running patch -p0 --forward --force;
patching file chrome/browser/resources/options2/browser_options_profile_list.js
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/options2/browser_options_profile_list.js.rej

[commit-bot: I haz the power, 2012-01-11 21:08:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csilv@chromium.org/9181013/10004

[commit-bot: I haz the power, 2012-01-11 21:08:42]

Can't apply patch for file
chrome/browser/resources/options2/browser_options_profile_list.js.
While running patch -p0 --forward --force;
patching file chrome/browser/resources/options2/browser_options_profile_list.js
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/options2/browser_options_profile_list.js.rej

[csilv, 2012-01-11 21:34:36]

Committing based on trybot results in patch set 3.