Issue 985: Default class without constructor does not cause a compile-time error

Issue 985: Default class without constructor does not cause a compile-time error
http://code.google.com/p/dart/issues/detail?id=985

R=mmendez,zundel
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3239

[codefu, 2012-01-10 21:53:23]

http://codereview.chromium.org/9168020/diff/1/compiler/javatests/com/google/d...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(left):

http://codereview.chromium.org/9168020/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:1102:
checkSourceErrors(
This formatting was my fault on a previous CL; just wrapping it in this one to
clean up.

http://codereview.chromium.org/9168020/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(right):

http://codereview.chromium.org/9168020/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:566: " 
factory A() {}",
For A() to be considered a constructor, it must have the factory keyword.  This,
etc others.

[mmendez, 2012-01-11 14:39:47]

lgtm

http://codereview.chromium.org/9168020/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Elements.java (right):

http://codereview.chromium.org/9168020/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Elements.java:543: return
element != null && element.getParameters().isEmpty();
Nit: double check the spec, but you may need to check the name of the
constructor as well.

[codefu, 2012-01-11 16:02:46]

http://codereview.chromium.org/9168020/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/Elements.java (right):

http://codereview.chromium.org/9168020/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/Elements.java:543: return
element != null && element.getParameters().isEmpty();
On 2012/01/11 14:39:47, mmendez wrote:
> Nit: double check the spec, but you may need to check the name of the
> constructor as well.

The code this replaced only tested if the constructor had no parameters
(constructor.getParameters().isEmpty()), however:
---
7.5:
If no constructor is specified for a class C, it implicitly has a default
constructor C() : super() {}, unless it is class Object.
---
So I'll add the name test as well.

[zundel, 2012-01-12 12:51:49]

lgtm2