compiler/java/com/google/dart/compiler/resolver/Resolver.java - Issue 9168020: Issue 985: Default class without constructor does not cause a compile-time error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/Resolver.java

Issue 9168020: Issue 985: Default class without constructor does not cause a compile-time error (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Nits Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/Elements.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/Resolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/Resolver.java b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

index 7d4c0ffc721dfd54d0322eda282f699d42cfd8d7..04b4ec872b08ca97c9830dbb99e087477b5bea21 100644

--- a/compiler/java/com/google/dart/compiler/resolver/Resolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/Resolver.java

@@ -1331,7 +1331,8 @@ public class Resolver {

}

// If constructor not found, try implicit default constructor of the default class.

- if (constructor.getParameters().isEmpty()

+ if (Elements.isDefaultConstructor(constructor)

+ && (Elements.isSyntheticConstructor(constructor) || factoryImplementsInterface)

&& Elements.needsImplicitDefaultConstructor(defaultClass)) {

return new SyntheticDefaultConstructorElement(null, defaultClass, typeProvider);

}