Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3742)

Unified Diff: chrome/browser/ui/webui/fileicon_source.h

Issue 9167019: Consolidate icon loading on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/fileicon_source.h
diff --git a/chrome/browser/ui/webui/fileicon_source.h b/chrome/browser/ui/webui/fileicon_source.h
index f42fabf4bde323edb623b5f6d85c05bd506b4448..983827a6deb45640f515aea11e69a21de21b31c1 100644
--- a/chrome/browser/ui/webui/fileicon_source.h
+++ b/chrome/browser/ui/webui/fileicon_source.h
@@ -8,6 +8,7 @@
#include <string>
+#include "base/file_path.h"
#include "chrome/browser/icon_manager.h"
#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
@@ -36,14 +37,17 @@ class FileIconSource : public ChromeURLDataManager::DataSource {
IconManager::Handle request_handle,
gfx::Image* icon);
- private:
+ protected:
virtual ~FileIconSource();
- CancelableRequestConsumerT<int, 0> cancelable_consumer_;
+ // Once the |path| and |icon_size| has been determined from the request, this
+ // function is called to perform the actual fetch.
+ virtual void FetchFileIcon(const FilePath& path,
+ IconLoader::IconSize icon_size,
+ int request_id);
- // Raw PNG representation of the favicon to show when the favicon
- // database doesn't have a favicon for a webpage.
- scoped_refptr<RefCountedBytes> default_favicon_;
+ private:
+ CancelableRequestConsumerT<int, 0> cancelable_consumer_;
DISALLOW_COPY_AND_ASSIGN(FileIconSource);
};

Powered by Google App Engine
This is Rietveld 408576698