chrome/browser/resources/downloads.js - Issue 9167019: Consolidate icon loading on ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/downloads.js

Issue 9167019: Consolidate icon loading on ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: " Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/downloads.js

diff --git a/chrome/browser/resources/downloads.js b/chrome/browser/resources/downloads.js

index ecdba4edce4826260012d10b55f736d5b97bd9d7..735326ca723b194f9e86176391dd512bd179172d 100644

--- a/chrome/browser/resources/downloads.js

+++ b/chrome/browser/resources/downloads.js

@@ -394,7 +394,8 @@ Download.prototype.update = function(download) {

this.safe_.style.display = 'none';

} else {

downloads.scheduleIconLoad(this.nodeImg_,

- 'chrome://fileicon/' + this.filePath_);

+ 'chrome://fileicon/' +

+ encodeURIComponent(this.filePath_));

achuithb 2012/01/23 20:59:27 please make sure this is tested on a chromeos devi

achuithb 2012/01/23 21:01:10 I should've phrased this better - we should make s

asanka 2012/01/26 00:49:35 Done.

if (this.state_ == Download.States.COMPLETE &&

!this.fileExternallyRemoved_) {