Fix dartc.sh script to use /bin/bash (issue dart:1104)

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 5ce6b7ebd94f01cc963a86a8a92704b3ad298115..50721c44ccce5ff0973b93c084c3eec6250e9010 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -103,7 +103,14 @@ class BrowserTestCase extends TestCase {
                                                   configuration,
                                                   completedHandler,
                                                   expectedOutcomes,
-                                                  isNegative);
+                                                  isNegative) {
+    if (compilerPath != null) {
+      commandLine = 'execution command: $commandLine';
+      String compilationCommand =
+          '$compilerPath ${Strings.join(compilerArguments, " ")}';

[ahe, 2012/01/10 13:55:03]

Shouldn't this be:

'$compilerPath "${Strings.join(compilerArguments, " ")}"'

[Bill Hesse, 2012/01/10 14:13:52]

No.  Why would it?  This is the human-readable one we print.  And even when
pasting, there shouldn't be quotes around the arguments. On 2012/01/10 13:55:03,
ahe wrote:

+      commandLine = 'compilation command: $compilationCommand\n$commandLine';
+    }
+  }
 }
 
 
@@ -186,9 +193,12 @@ class RunningProcess {
 
   void compilerExitHandler(int exitCode) {
     if (exitCode != 0) {
+      stderr.add('test.dart: Compilation step failed (exit code $exitCode)\n');
       exitHandler(exitCode);
     } else {
       process.close();
+      stderr.add('test.dart: Compilation finished, starting execution\n');
+      stdout.add('test.dart: Compilation finished, starting execution\n');

[zundel, 2012/01/10 14:04:53]

do we really need 2 lines of output?

[Bill Hesse, 2012/01/10 14:13:52]

These lines are acting as separators in stderr and stdout.  stderr and stdout
are printed separately, not intermingled, in error output, so we need both.

On 2012/01/10 14:04:53, zundel wrote:
I think so.  Each of these are lines are really long.

       runCommand(testCase.executablePath, testCase.arguments, exitHandler);
     }
   }