Event listener not removed correctly in autocomplete list

Fix removeEventListener call in autocomplete_list.js so that it will actually remove the listener.

If you add an event listener using addEventListener with the 3rd argument as |true|, you also need to call removeEventListener with the 3rd argument as |true|, otherwise it will not actually be removed.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117120

[Tyler Breisacher (Chromium), 2012-01-09 19:25:06]

Just a small issue I noticed while working on this autocomplete code. Simplified
demo of the issue:

<button id='b'>b</button>
<button onclick="add();">add</button>
<button onclick="remove();">remove</button>

<script>
  var b = document.getElementById('b');
  
  function f() {
    console.log('clicked');
  }

  function add() {
    b.addEventListener('click', f, true);
  }

  function remove() {
    b.removeEventListener('click', f);
  }
</script>

Click add, then remove, then b. Note that the listener is still attached.

http://codereview.chromium.org/9158002/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/autocomplete_list.js (right):

http://codereview.chromium.org/9158002/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/autocomplete_list.js:164:
input.addEventListener('keydown', this.textFieldKeyHandler_, true);
Event is added here with |true| for the "use capture" parameter.

[stuartmorgan, 2012-01-10 07:48:41]

LGTM

Since you are working in this code, it would be great if you could move this out
of options/ and into one of the common JS UI directories in a follow-up. There's
no reason we should have two copies of this utility class, and patching it in
two places for however long options2 is being developed is busywork (and
error-prone).

[Tyler Breisacher (Chromium), 2012-01-11 00:14:34]

Not a bad idea -> http://codereview.chromium.org/9168026