Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1999)

Unified Diff: runtime/vm/isolate.cc

Issue 9148051: Provide API support for weak handles and post-mortem finalization. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: a better strategy for protected handle checks Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 6a5e829711e65f7f50b98f35da25ac0cca7cad41..4b3993b2e564773288f554ea4087378a9b7591ee 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -333,13 +333,6 @@ RawObject* Isolate::StandardRunLoop() {
void Isolate::VisitObjectPointers(ObjectPointerVisitor* visitor,
bool validate_frames) {
- VisitStrongObjectPointers(visitor, validate_frames);
- VisitWeakObjectPointers(visitor);
-}
-
-
-void Isolate::VisitStrongObjectPointers(ObjectPointerVisitor* visitor,
- bool validate_frames) {
ASSERT(visitor != NULL);
// Visit objects in the object store.
@@ -361,7 +354,7 @@ void Isolate::VisitStrongObjectPointers(ObjectPointerVisitor* visitor,
// Visit the dart api state for all local and persistent handles.
if (api_state() != NULL) {
- api_state()->VisitStrongObjectPointers(visitor);
+ api_state()->VisitObjectPointers(visitor);
}
// Visit all objects in the code index table.
@@ -377,9 +370,9 @@ void Isolate::VisitStrongObjectPointers(ObjectPointerVisitor* visitor,
}
-void Isolate::VisitWeakObjectPointers(ObjectPointerVisitor* visitor) {
+void Isolate::VisitWeakPersistentHandles(HandleVisitor* visitor) {
if (api_state() != NULL) {
- api_state()->VisitWeakObjectPointers(visitor);
+ api_state()->VisitWeakHandles(visitor);
}
}

Powered by Google App Engine
This is Rietveld 408576698