Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: runtime/vm/handles.h

Issue 9148051: Provide API support for weak handles and post-mortem finalization. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: a better strategy for protected handle checks Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/handles.h
diff --git a/runtime/vm/handles.h b/runtime/vm/handles.h
index 94b5fd467985f2837c428ac338ff59c46f0fd10f..4eb512922aa5931aba87b41f47c2a4f112b31fd5 100644
--- a/runtime/vm/handles.h
+++ b/runtime/vm/handles.h
@@ -60,7 +60,7 @@ class ObjectPointerVisitor;
class HandleVisitor {
public:
- virtual void Visit(uword* addr) = 0;
+ virtual void VisitHandle(uword* addr) = 0;
Ivan Posva 2012/01/12 23:30:38 uword is already an address type, so please just u
cshapiro 2012/01/13 01:30:03 Done (here and in the callers).
virtual ~HandleVisitor() {
}
@@ -82,7 +82,7 @@ class Handles {
// Visit all object pointers stored in the various handles.
void VisitObjectPointers(ObjectPointerVisitor* visitor);
- // Visits all of the various handles.
+ // Visit all of the various handles.
void Visit(HandleVisitor* visitor);
// Allocates a handle in the current handle scope. This handle is valid only

Powered by Google App Engine
This is Rietveld 408576698