Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 9148030: lastchange: don't check git state for whether the tree is dirty (Closed)

Created:
8 years, 11 months ago by Evan Martin
Modified:
8 years, 11 months ago
Reviewers:
haraken, Denis Lagno
CC:
chromium-reviews
Visibility:
Public.

Description

lastchange: don't check git state for whether the tree is dirty We don't show whether the tree was dirty for SVN. Because lastchange runs on every build, these commands impact every build. The call to "git checkout" makes git stat every file in the repository (including ones unrelated to the build). This change makes a Ninja build of Chrome 20% faster. I've seen the command take tens of seconds on a cold disk, and it likely has a larger impact on Windows where the disk is slower. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M build/util/lastchange.py View 2 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
8 years, 11 months ago (2012-01-11 19:37:38 UTC) #1
haraken
On 2012/01/11 19:37:38, Evan Martin wrote: LGTM > This change makes a Ninja build of ...
8 years, 11 months ago (2012-01-11 23:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/evan@chromium.org/9148030/1
8 years, 11 months ago (2012-01-11 23:57:56 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-12 01:46:34 UTC) #4
Change committed as 117352

Powered by Google App Engine
This is Rietveld 408576698