Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: build/util/lastchange.py

Issue 9148030: lastchange: don't check git state for whether the tree is dirty (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/util/lastchange.py
diff --git a/build/util/lastchange.py b/build/util/lastchange.py
index 870bf07459da14c7a69b591a2aa2cc59b8740932..cbe92bb79dbb742f41e2811328c0876783a12443 100755
--- a/build/util/lastchange.py
+++ b/build/util/lastchange.py
@@ -135,30 +135,6 @@ def FetchGitSVNURLAndRevision(directory, svn_url_regex):
return None, None
-def IsGitSVNDirty(directory):
- """
- Checks whether our git-svn tree contains clean trunk or any local changes.
-
- Errors are swallowed.
- """
- proc = RunGitCommand(directory, ['log', '-1'])
- if proc:
- output = proc.communicate()[0].strip()
- if proc.returncode == 0 and output:
- # Extract the latest SVN revision and the SVN URL.
- # The target line is the last "git-svn-id: ..." line like this:
- # git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85528 0039d316....
- match = _GIT_SVN_ID_REGEX.search(output)
- if match:
- # Check if there are any local uncommitted changes.
- proc = RunGitCommand(directory, ['checkout'])
- if proc:
- output = proc.communicate()[0].strip()
- if proc.returncode == 0 and not output:
- return False
- return True
-
-
def FetchGitSVNRevision(directory, svn_url_regex):
"""
Fetch the Git-SVN identifier for the local tree.
@@ -167,8 +143,6 @@ def FetchGitSVNRevision(directory, svn_url_regex):
"""
url, revision = FetchGitSVNURLAndRevision(directory, svn_url_regex)
if url and revision:
- if IsGitSVNDirty(directory):
- revision = revision + '-dirty'
return VersionInfo(url, revision)
return None
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698