Issue 9148018: [Coverity] Fixed call by value to by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9148018: [Coverity] Fixed call by value to by reference (Closed)

Created:
8 years, 11 months ago by groby-ooo-7-16

Modified:
8 years, 11 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Coverity] Fixed call by value to by reference CID=102901 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117360

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	base/file_util_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/redirect_to_file_resource_handler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/redirect_to_file_resource_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/net/url_fetcher_impl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM Is this just to reduce code bloat / improve performance?

8 years, 11 months ago (2012-01-11 21:26:51 UTC) #2

groby-ooo-7-16

Yep - we've set Coverity to complain whenever we pass a structure of more than ...

8 years, 11 months ago (2012-01-11 22:47:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/9148018/1

8 years, 11 months ago (2012-01-12 00:32:42 UTC) #4

Change committed as 117360

Expand Messages | Collapse Messages