content/browser/renderer_host/redirect_to_file_resource_handler.cc - Issue 9148018: [Coverity] Fixed call by value to by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/redirect_to_file_resource_handler.cc

Issue 9148018: [Coverity] Fixed call by value to by reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/redirect_to_file_resource_handler.cc

diff --git a/content/browser/renderer_host/redirect_to_file_resource_handler.cc b/content/browser/renderer_host/redirect_to_file_resource_handler.cc

index 1c10a3e0a7bcedd7245d2ad9d9abe617117786af..54329db573f9184f25af4cb880602120aa31f1d7 100644

--- a/content/browser/renderer_host/redirect_to_file_resource_handler.cc

+++ b/content/browser/renderer_host/redirect_to_file_resource_handler.cc

@@ -153,7 +153,7 @@ RedirectToFileResourceHandler::~RedirectToFileResourceHandler() {

void RedirectToFileResourceHandler::DidCreateTemporaryFile(

base::PlatformFileError /*error_code*/,

base::PassPlatformFile file_handle,

- FilePath file_path) {

+ const FilePath& file_path) {

if (request_was_closed_) {

// If the request was already closed, then don't bother allocating the

// file_stream_ (otherwise we will leak it).