Hook up the dartdoc tests to test.py, test.dart, and frog/presubmit.py.

utils/dartdoc/html_renderer.dart

Index: utils/dartdoc/html_renderer.dart
diff --git a/utils/dartdoc/html_renderer.dart b/utils/dartdoc/html_renderer.dart
index ec4bebb1d00316bb270b484f635f59d5fdfe4490..1665d86aebe7a85cc3e8c0a78e52ce0b8f80fc83 100644
--- a/utils/dartdoc/html_renderer.dart
+++ b/utils/dartdoc/html_renderer.dart
@@ -34,7 +34,10 @@ class HtmlRenderer implements NodeVisitor {
 
     buffer.add('<${element.tag}');
 
-    for (final name in element.attributes.getKeys()) {
+    // Sort the keys so that we generate stable output.
+    final attributeNames = new List.from(element.attributes.getKeys());

[Jennifer Messerly, 2012/01/11 19:15:10]

Frog has an "orderValuesByKeys" method we use when we want just the values
(frog/utils.dart). You could add a version called something like "orderKeys":

/** Sorts the map by the key. */
List orderKeys(Map map) {
  // TODO(jmesserly): it'd be nice to have SortedMap in corelib.
  List keys = map.getKeys();
  keys.sort((x, y) => x.compareTo(y));
  return keys;
}

then use it like:

for (name in orderKeys(element.attributes)) { ... }

btw, you shouldn't need to copy the result of getKeys. For better or worse, it
already does that in the current design (and if it changes to return an O(1)
wrapper, we'll have to fix other places in the code, so IMO it's safe to rely on
that fact).

[Bob Nystrom, 2012/01/11 21:28:47]

Dartdoc is coupled to frog but this little markdown sublibrary isn't. I could
pull this out into its own function but that seemed like overkill for now.
Changed, but man that feels gross. :( It should return an O(1) immutable
collection.

+    attributeNames.sort((a, b) => a.compareTo(b));
+    for (final name in attributeNames) {
       buffer.add(' $name="${element.attributes[name]}"');
     }