Hook up the dartdoc tests to test.py, test.dart, and frog/presubmit.py.

utils/dartdoc/html_renderer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 String renderToHtml(List<Node> nodes) => new HtmlRenderer().render(nodes);
 
 /// Translates a parsed AST to HTML.
 class HtmlRenderer implements NodeVisitor {
   static final _BLOCK_TAGS = const RegExp(
       'blockquote|h1|h2|h3|h4|h5|h6|hr|p|pre');
@@ skipping 16 matching lines @@
 
   bool visitElementBefore(Element element) {
     // Hackish. Separate block-level elements with newlines.
     if (!buffer.isEmpty() &&
         _BLOCK_TAGS.firstMatch(element.tag) != null) {
       buffer.add('\n');
     }
 
     buffer.add('<${element.tag}');
 
-    for (final name in element.attributes.getKeys()) {
+    // Sort the keys so that we generate stable output.
+    final attributeNames = new List.from(element.attributes.getKeys());

[Jennifer Messerly, 2012/01/11 19:15:10]

Frog has an "orderValuesByKeys" method we use when we want just the values
(frog/utils.dart). You could add a version called something like "orderKeys":

/** Sorts the map by the key. */
List orderKeys(Map map) {
  // TODO(jmesserly): it'd be nice to have SortedMap in corelib.
  List keys = map.getKeys();
  keys.sort((x, y) => x.compareTo(y));
  return keys;
}

then use it like:

for (name in orderKeys(element.attributes)) { ... }

btw, you shouldn't need to copy the result of getKeys. For better or worse, it
already does that in the current design (and if it changes to return an O(1)
wrapper, we'll have to fix other places in the code, so IMO it's safe to rely on
that fact).

[Bob Nystrom, 2012/01/11 21:28:47]

Dartdoc is coupled to frog but this little markdown sublibrary isn't. I could
pull this out into its own function but that seemed like overkill for now.
Changed, but man that feels gross. :( It should return an O(1) immutable
collection.

+    attributeNames.sort((a, b) => a.compareTo(b));
+    for (final name in attributeNames) {
       buffer.add(' $name="${element.attributes[name]}"');
     }
 
     if (element.isEmpty) {
       // Empty element like <hr/>.
       buffer.add(' />');
       return false;
     } else {
       buffer.add('>');
       return true;
     }
   }
 
   void visitElementAfter(Element element) {
     buffer.add('</${element.tag}>');
   }
 }